Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a8728728ea0d85f52ec9162e6cee680f854fa5a7
https://github.com/WebKit/WebKit/commit/a8728728ea0d85f52ec9162e6cee680f854fa5a7
Author: Rahim Abdi <[email protected]>
Date: 2025-05-10 (Sat, 10 May 2025)
Changed paths:
M LayoutTests/accessibility/mac/search-predicate-expected.txt
M LayoutTests/accessibility/mac/search-predicate.html
M LayoutTests/platform/mac-wk1/accessibility/roles-exposed-expected.txt
M LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm
M Source/WebCore/accessibility/mac/CocoaAccessibilityConstants.h
M Source/WebCore/en.lproj/Localizable.strings
M Source/WebCore/platform/LocalizedStrings.cpp
Log Message:
-----------
AX: Vend AXSubrole=AXLandmarkForm for labeled form elements
https://bugs.webkit.org/show_bug.cgi?id=233907
rdar://86135614
Reviewed by Tyler Wilcock.
Per ARIA specification, elements with a role of "form" (i.e., <form> or
role="form") require an accessible name
and when not provided, this is an authoring error:
https://w3c.github.io/aria/#document-handling_author-errors_roles.
Form elements can be labelled like other landmarks (e.g., via aria-label,
aria-labelledby) and additionally, native <form> elements
can be labeled with the title attribute.
This commit ensures that form elements are exposed as navigable landmarks when
supplied with an accname. Form elements also now
vend AXSubrole=AXLandmarkForm to align with the classification of other
landmarks.
* LayoutTests/accessibility/mac/search-predicate-expected.txt: Updated test
expectation.
* LayoutTests/accessibility/mac/search-predicate.html: Updated <form> test.
* LayoutTests/platform/mac-wk1/accessibility/roles-exposed-expected.txt Updated
test expectation.
* LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt Updated
test expectation.
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::isLandmark const):
(WebCore::AXCoreObject::ariaLandmarkRoleDescription const):
* Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::subrolePlatformString const):
* Source/WebCore/accessibility/mac/CocoaAccessibilityConstants.h:
* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::AXARIAContentGroupText):
Canonical link: https://commits.webkit.org/294748@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
