Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0983be4b7d0cab884896063398694a7cdfdbf1d5
https://github.com/WebKit/WebKit/commit/0983be4b7d0cab884896063398694a7cdfdbf1d5
Author: Joshua Hoffman <[email protected]>
Date: 2025-05-09 (Fri, 09 May 2025)
Changed paths:
A
LayoutTests/accessibility/mac/input-type-role-description-dynamic-expected.txt
A LayoutTests/accessibility/mac/input-type-role-description-dynamic.html
M LayoutTests/platform/mac-wk1/accessibility/roles-exposed-expected.txt
M Source/WebCore/Headers.cmake
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/AccessibilityAttachment.cpp
M Source/WebCore/accessibility/AccessibilityAttachment.h
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/html/HTMLInputElement.h
Log Message:
-----------
AX: Move roleDescription and rolePlatformDescription to AXCoreObject
https://bugs.webkit.org/show_bug.cgi?id=292692
rdar://150890881
Reviewed by Tyler Wilcock.
Moving roleDescription and rolePlatformDescription to AXCoreObject allows
us to not have to cache the full role description for every single object
(when applicable). Instead, we can use some existing properties, as well
as a new one, InputType, to compute this on and off the main thread.
As part of this change, several properties that we cached previously can
be removed in favor of using the single InputType cached on inputs.
I've also updated the WK1 test expectations for
accessibility/roles-exposed.html.
The datetime-local, date, month, week, time are not supported on WK1, so we
shouldn't have those in our expectations.
*
LayoutTests/accessibility/mac/input-type-role-description-dynamic-expected.txt:
Added.
* LayoutTests/accessibility/mac/input-type-role-description-dynamic.html: Added.
* LayoutTests/platform/mac-wk1/accessibility/roles-exposed-expected.txt:
* Source/WebCore/Headers.cmake:
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::isFileUploadButton const):
(WebCore::AXCoreObject::isInputImage const):
(WebCore::AXCoreObject::supportsARIARoleDescription const):
(WebCore::AXCoreObject::isRadioInput const):
(WebCore::AXCoreObject::roleDescription):
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::AXCoreObject::rolePlatformDescription):
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleRoleChanged):
(WebCore::AXObjectCache::handleARIARoleDescriptionChanged):
(WebCore::AXObjectCache::handleInputTypeChanged):
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):
(WebCore::AXObjectCache::handleRoleDescriptionChanged): Deleted.
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityAttachment.cpp:
(WebCore::AccessibilityAttachment::attachmentElement const):
(WebCore::AccessibilityAttachment::roleDescription): Deleted.
* Source/WebCore/accessibility/AccessibilityAttachment.h:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isInputImage const): Deleted.
(WebCore::AccessibilityNodeObject::isRadioInput const): Deleted.
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::inputType const):
(WebCore::AccessibilityObject::rolePlatformDescription): Deleted.
(WebCore::AccessibilityObject::supportsARIARoleDescription const): Deleted.
(WebCore::AccessibilityObject::roleDescription): Deleted.
(WebCore::AccessibilityObject::isFileUploadButton const): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isMediaTimeline const):
(WebCore::AccessibilityObject::isSliderThumb const):
(WebCore::AccessibilityObject::isDescriptionList const): Deleted.
* Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm:
(WebCore::AXCoreObject::rolePlatformDescription):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::setProperty):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperties):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
* Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::rolePlatformDescription): Deleted.
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::inputType const):
* Source/WebCore/html/HTMLInputElement.h:
Canonical link: https://commits.webkit.org/294712@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
