Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f2acaec3c9a77a441ed73ba264e743b8f5cf9616
      
https://github.com/WebKit/WebKit/commit/f2acaec3c9a77a441ed73ba264e743b8f5cf9616
  Author: Sammy Gill <[email protected]>
  Date:   2025-05-09 (Fri, 09 May 2025)

  Changed paths:
    M Source/WebCore/rendering/FlexLineBuilder.cpp
    M Source/WebCore/rendering/FlexLineBuilder.h
    M Source/WebCore/rendering/RenderFlexibleBox.cpp

  Log Message:
  -----------
  [Flex] Refactor computeNextFlexLine to return a struct
https://bugs.webkit.org/show_bug.cgi?id=292748
rdar://150969447

Reviewed by Alan Baradlay.

This function signature has many arguments that are passed in by
reference to use to write data out. We can use a struct instead which
improves the readability of the codebase by decluttering it a bit and
the maintainability by encapsulating the data together.

I named this struct "FlexingLineData," because it contains the flex
items which are placed on the line along with other pieces of data which
are used as input to flexing the content on the line.

* Source/WebCore/rendering/FlexLineBuilder.cpp:
(WebCore::FlexLineBuilder::computeNextFlexLine):
* Source/WebCore/rendering/FlexLineBuilder.h:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::performFlexLayout):

Canonical link: https://commits.webkit.org/294706@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to