Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 861940cc5a60857216cd3b21583816717e7706db
https://github.com/WebKit/WebKit/commit/861940cc5a60857216cd3b21583816717e7706db
Author: Ryosuke Niwa <[email protected]>
Date: 2025-05-07 (Wed, 07 May 2025)
Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/Modules/push-api/PushSubscriptionOwner.h
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/KeyboardEvent.cpp
M Source/WebCore/dom/MouseRelatedEvent.cpp
M Source/WebCore/history/CachedFrame.h
M Source/WebCore/history/CachedPage.h
M Source/WebCore/html/PDFDocument.cpp
R Source/WebCore/page/Base64Utilities.cpp
R Source/WebCore/page/Base64Utilities.h
M Source/WebCore/page/DOMWindow.cpp
M Source/WebCore/page/DOMWindowExtension.cpp
M Source/WebCore/page/DeviceController.cpp
M Source/WebCore/page/Frame.cpp
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebCore/page/LocalDOMWindow.h
M Source/WebCore/page/LocalDOMWindowProperty.cpp
M Source/WebCore/page/Location.cpp
M Source/WebCore/page/NavigationHistoryEntry.h
M Source/WebCore/page/WebKitNamespace.cpp
M Source/WebCore/page/WindowOrWorkerGlobalScope.cpp
M Source/WebCore/page/WindowOrWorkerGlobalScope.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/workers/WorkerGlobalScope.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
Log Message:
-----------
Reduce header includes in LocalDOMWindow.h
https://bugs.webkit.org/show_bug.cgi?id=292655
Reviewed by Brent Fulgham.
Reduced #include in LocalDOMWindow.h to improve the build time.
This PR also merges Base64Utilities into WindowOrWorkerGlobalScope and make
LocalDOMWindow
lazily construct PushManager in LocalDOMWindow::pushManager instead of eagerly
constructing it
in LocalDOMWindow::LocalDOMWindow.
* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/push-api/PushSubscriptionOwner.h:
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:
(WebCore::DialogHandler::dialogCreated):
* Source/WebCore/dom/Element.cpp:
* Source/WebCore/dom/KeyboardEvent.cpp:
(WebCore::viewIsCompositing):
(WebCore::KeyboardEvent::charCode const):
* Source/WebCore/dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::frameViewFromWindowProxy):
* Source/WebCore/history/CachedFrame.h:
* Source/WebCore/history/CachedPage.h:
* Source/WebCore/html/PDFDocument.cpp:
* Source/WebCore/page/Base64Utilities.cpp: Removed.
* Source/WebCore/page/Base64Utilities.h: Removed.
* Source/WebCore/page/DOMWindow.cpp:
(WebCore::DOMWindow::btoa):
(WebCore::DOMWindow::atob):
* Source/WebCore/page/DOMWindowExtension.cpp:
(WebCore::DOMWindowExtension::frame const):
* Source/WebCore/page/DeviceController.cpp:
* Source/WebCore/page/Frame.cpp:
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::dispatchAllPendingBeforeUnloadEvents):
(WebCore::LocalDOMWindow::allowPopUp):
(WebCore::ContextDestructionObserver):
(WebCore::LocalDOMWindow::isCurrentlyDisplayedInFrame const):
(WebCore::LocalDOMWindow::collectMatchingElementsInFlatTree):
(WebCore::LocalDOMWindow::matchingElementInFlatTree):
(WebCore::LocalDOMWindow::orientation const):
(WebCore::LocalDOMWindow::processPostMessage):
(WebCore::LocalDOMWindow::focus):
(WebCore::LocalDOMWindow::blur):
(WebCore::LocalDOMWindow::print):
(WebCore::LocalDOMWindow::stop):
(WebCore::LocalDOMWindow::alert):
(WebCore::LocalDOMWindow::confirmForBindings):
(WebCore::LocalDOMWindow::prompt):
(WebCore::LocalDOMWindow::find const):
(WebCore::LocalDOMWindow::outerHeight const):
(WebCore::LocalDOMWindow::outerWidth const):
(WebCore::LocalDOMWindow::innerHeight const):
(WebCore::LocalDOMWindow::innerWidth const):
(WebCore::LocalDOMWindow::screenX const):
(WebCore::LocalDOMWindow::screenY const):
(WebCore::LocalDOMWindow::scrollX const):
(WebCore::LocalDOMWindow::scrollY const):
(WebCore::LocalDOMWindow::name const):
(WebCore::LocalDOMWindow::setName):
(WebCore::LocalDOMWindow::disownOpener):
(WebCore::LocalDOMWindow::getMatchedCSSRules const):
(WebCore::LocalDOMWindow::scrollBy const):
(WebCore::LocalDOMWindow::scrollTo const):
(WebCore::LocalDOMWindow::allowedToChangeWindowGeometry const):
(WebCore::LocalDOMWindow::incrementScrollEventListenersCount):
(WebCore::LocalDOMWindow::decrementScrollEventListenersCount):
(WebCore::LocalDOMWindow::dispatchLoadEvent):
(WebCore::LocalDOMWindow::dispatchEvent):
(WebCore::LocalDOMWindow::finishedLoading):
(WebCore::LocalDOMWindow::setLocation):
(WebCore::LocalDOMWindow::open):
(WebCore::LocalDOMWindow::showModalDialog):
(WebCore::LocalDOMWindow::frame const):
(WebCore::LocalDOMWindow::localFrame const):
(WebCore::LocalDOMWindow::protectedFrame const):
(WebCore::LocalDOMWindow::pushManager):
(WebCore::toScope):
(WebCore::m_pushManager): Deleted.
* Source/WebCore/page/LocalDOMWindow.h:
* Source/WebCore/page/LocalDOMWindowProperty.cpp:
(WebCore::LocalDOMWindowProperty::frame const):
* Source/WebCore/page/Location.cpp:
(WebCore::Location::replace):
(WebCore::Location::setLocation):
* Source/WebCore/page/NavigationHistoryEntry.h:
* Source/WebCore/page/WebKitNamespace.cpp:
* Source/WebCore/page/WindowOrWorkerGlobalScope.cpp:
(WebCore::WindowOrWorkerGlobalScope::btoa):
(WebCore::WindowOrWorkerGlobalScope::atob):
* Source/WebCore/page/WindowOrWorkerGlobalScope.h:
* Source/WebCore/testing/Internals.cpp:
* Source/WebCore/workers/WorkerGlobalScope.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::remotePostMessage):
Canonical link: https://commits.webkit.org/294653@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
