Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c454535205e231eb4c5c84941530f361adf2e464
      
https://github.com/WebKit/WebKit/commit/c454535205e231eb4c5c84941530f361adf2e464
  Author: Alan Baradlay <[email protected]>
  Date:   2025-05-02 (Fri, 02 May 2025)

  Changed paths:
    M Source/WebCore/rendering/style/RenderStyle.cpp

  Log Message:
  -----------
  [Repaint] Changing text-decoration-color on ancestor block has no affect on 
inline content
https://bugs.webkit.org/show_bug.cgi?id=292373

Reviewed by Antti Koivisto.

Text decoration properties are propagated to descendant content even crossing 
block containers.
e.g.
 <div style="text-decoration-color: red"><div><div>this should have red 
decoration color</div></div></div>

This is achieved in TextBoxPainter by climbing the ancestor chain collecting 
text decoration related values (as opposed to through style inheritance).
Considering this propagating behavior StyleDifference::RepaintIfText was never 
a valid repaint optimization for text-decoration.

* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::miscDataChangeRequiresRepaint):
(WebCore::rareDataChangeRequiresRepaint):
(WebCore::RenderStyle::changeRequiresRepaintIfText const):

Canonical link: https://commits.webkit.org/294424@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to