Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cb3d85a1036043254c10ac4e2299d639c4a1843b
https://github.com/WebKit/WebKit/commit/cb3d85a1036043254c10ac4e2299d639c4a1843b
Author: Richard Robinson <[email protected]>
Date: 2025-05-01 (Thu, 01 May 2025)
Changed paths:
M Source/WebKit/SaferCPPExpectations/NoUnretainedMemberCheckerExpectations
R Source/WebKit/UIProcess/Cocoa/WKTextExtractionItem.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
A Source/WebKit/WebKitSwift/TextExtraction/WKTextExtractionItem.h
M Source/WebKit/WebKitSwift/WebKitSwift.h
M Source/WebKit/WebKitSwift/module.modulemap
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm
M Tools/WebKitTestRunner/cocoa/WKTextExtractionTestingHelpers.mm
Log Message:
-----------
[Swift in WebKit] Stop accidentally exposing WebKitSwift as SPI
https://bugs.webkit.org/show_bug.cgi?id=292361
rdar://150424287
Reviewed by Elliott Williams.
WebKitSwift is currently somewhat exposed as SPI due to various headers
mistakenly using "private" visability.
Correct this, and fix other inconsistent WKS infrastructure issues.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Enforce consistency with regards to header visibility across all WKS headers.
Specifically, each
header should be part of both WebKit and WebKitSwift, and should have
project-level visibility for each.
* Source/WebKit/WebKitSwift/TextExtraction/WKTextExtractionItem.h: Renamed from
Source/WebKit/UIProcess/Cocoa/WKTextExtractionItem.h.
Enforce consistency with regards to the location of WKS types. All headers for
WKS types should be in WKS.
* Source/WebKit/WebKitSwift/WebKitSwift.h:
Make this header project-level. In addition, since each child header file is
also project, use normal quotes
instead of angle quotes for the imports.
* Source/WebKit/WebKitSwift/module.modulemap:
The header need not be umbrella, so remove this. This makes it more consistent
with WebKitInternal.h
* Tools/WebKitTestRunner/cocoa/WKTextExtractionTestingHelpers.mm:
This file is a weird edge-case wherein a different project needs access to a
WKS type. For this case particularly,
this is resolved by forward-declaring the types. Text extraction will
eventually move to WK proper, so this is
just temporary anyways.
Canonical link: https://commits.webkit.org/294413@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
