Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 35b37af60e645aa9c67a1fdd55126aee51a40b13
      
https://github.com/WebKit/WebKit/commit/35b37af60e645aa9c67a1fdd55126aee51a40b13
  Author: Kiara Rose <[email protected]>
  Date:   2025-04-22 (Tue, 22 Apr 2025)

  Changed paths:
    M Source/WebCore/loader/DocumentLoader.h
    M Source/WebCore/loader/PolicyChecker.cpp
    M Source/WebCore/loader/cache/CachedResourceLoader.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm

  Log Message:
  -----------
  about:blank appears in back/forward cache after a declarativeNetRequest 
redirect
https://bugs.webkit.org/show_bug.cgi?id=291860
rdar://149306346

Reviewed by Alex Christensen.

Remove the code added in https://bugs.webkit.org/show_bug.cgi?id=291556 that 
caused about:blank
to appear in the back/forward cache after redirects. This change also 
introduces a different fix
that 291556 was trying to resolve, which is to apply the DNR rules for requests 
before we decide the
policy for the navigation. This will allow us to update the request with the 
redirected URL earlier
in the pipeline and allow cross-site redirects to work.

* Source/WebCore/loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
Only attempt to apply the rules if we have set the 
activeContentRuleListPatterns.
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
(TEST_F(WKContentRuleListStoreTest,
MainResourceCrossOriginRedirectFromLoadedPageWithoutActivePatterns)):
Add a check to ensure that navigating back doesn't land on about:blank.
Change the structure of the alert on the original page that's loaded to ensure 
it reappears when we
test the backward navigation.

Canonical link: https://commits.webkit.org/293974@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to