Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 07ef022d64f027c0dcd2caf433980dd8b094d488
https://github.com/WebKit/WebKit/commit/07ef022d64f027c0dcd2caf433980dd8b094d488
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2025-04-15 (Tue, 15 Apr 2025)
Changed paths:
M
Source/WebKit/SaferCPPExpectations/UnretainedLambdaCapturesCheckerExpectations
M Source/WebKit/WebProcess/Plugins/PDF/PDFAnnotationTypeHelpers.mm
Log Message:
-----------
[Safer CPP] Address UnretainedLambdaCapturesChecker warnings in
PDFAnnotationTypeHelpers.mm
https://bugs.webkit.org/show_bug.cgi?id=291592
rdar://149332108
Reviewed by Chris Dumez.
This patch addresses the following warnings:
```
/Volumes/Data/worker/macOS-Safer-CPP-Checks-EWS/build/Source/WebKit/WebProcess/Plugins/PDF/PDFAnnotationTypeHelpers.mm:87:21:
warning: Captured raw-pointer 'annotation' to unretained type is unsafe
[alpha.webkit.UnretainedLambdaCapturesChecker]
87 | auto checker = [annotation, converter = WTFMove(converter)](auto&&
type) {
| ^
```
... by retaining `annotation` during capture instantiation.
*
Source/WebKit/SaferCPPExpectations/UnretainedLambdaCapturesCheckerExpectations:
* Source/WebKit/WebProcess/Plugins/PDF/PDFAnnotationTypeHelpers.mm:
(WebKit::PDFAnnotationTypeHelpers::annotationCheckerInternal):
Canonical link: https://commits.webkit.org/293745@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
