Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2849642af1de43e01cbba070d8c27d0f0c1111c6 https://github.com/WebKit/WebKit/commit/2849642af1de43e01cbba070d8c27d0f0c1111c6 Author: Rupin Mittal <ru...@apple.com> Date: 2025-04-11 (Fri, 11 Apr 2025)
Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm Log Message: ----------- Fix crash in Local & Session state restoration https://bugs.webkit.org/show_bug.cgi?id=291460 rdar://149079586 Reviewed by Wenson Hsieh. WKWebView::fetchDataOfTypes expects a Objective-C block completionHandler but WKWebView::_fetchDataOfTypes is passing in a C++ lambda. So the completion handler being captured may not be getting captured properly. Fix this so an Objective-C block is passed in. The same applies for the other API functions: WKWebView::restoreData, WKWebsiteDataStore::fetchDataOfTypes, and WKWebsiteDataStore::restoreData. * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _fetchDataOfTypes:completionHandler:]): (-[WKWebView _restoreData:completionHandler:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (-[WKWebsiteDataStore _fetchDataOfTypes:completionHandler:]): (-[WKWebsiteDataStore _restoreData:completionHandler:]): Canonical link: https://commits.webkit.org/293615@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes