Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 932707eee9bb5f7afe49a057f30796e558f8a48b https://github.com/WebKit/WebKit/commit/932707eee9bb5f7afe49a057f30796e558f8a48b Author: Sihui Liu <sihui_...@apple.com> Date: 2025-04-11 (Fri, 11 Apr 2025)
Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations M LayoutTests/storage/indexeddb/modern/resources/deletedatabase-1.js M LayoutTests/storage/indexeddb/modern/resources/deleteindex-4.js M LayoutTests/storage/indexeddb/modern/resources/double-abort.js M LayoutTests/storage/indexeddb/modern/resources/idbdatabase-deleteobjectstore-failures.js M LayoutTests/storage/indexeddb/modern/resources/idbdatabase-transaction-failures.js M LayoutTests/storage/indexeddb/modern/resources/idbtransaction-objectstore-failures.js M LayoutTests/storage/indexeddb/modern/resources/index-5.js M LayoutTests/storage/indexeddb/modern/resources/transaction-scheduler-1.js M LayoutTests/storage/indexeddb/modern/resources/transaction-scheduler-2.js M LayoutTests/storage/indexeddb/resources/shared.js Log Message: ----------- [Site Isolation] Make more storage/indexeddb/modern tests pass on bot rdar://148863016 https://bugs.webkit.org/show_bug.cgi?id=291295 Reviewed by Per Arne Vollan. When running test in cross-origin iframe with site isolation enabled, the result dumping can be async: subframe process sends message to UI process, UI process notifies main frame process, and main frame process dumps the result. This means when site isolation is enabled, test script in subframe might proceed further, and this could lead dumped result to be different from when site isolation is disabled and result dumping is sync in one process. For these specific tests, we don't expect more events to be handled or more logs after all expected script code is executed (notifyDone() is called), so we can just remove the event listener and avoid logging after tests are marked as ended. * LayoutTests/platform/mac-site-isolation/TestExpectations: * LayoutTests/storage/indexeddb/modern/resources/deletedatabase-1.js: (prepareDatabase.event.target.transaction.onabort): (prepareDatabase.event.target.transaction.onerror): (prepareDatabase): (continueTest1.request.onerror): (continueTest1.request.onupgradeneeded): (continueTest1): (continueTest2.versionTransaction.oncomplete): (continueTest2.versionTransaction.onabort): (continueTest2.versionTransaction.onerror): (continueTest2.request.onupgradeneeded): (continueTest2.request.onsuccess): (continueTest2.request.onerror): (continueTest2): (done): Deleted. (log): Deleted. * LayoutTests/storage/indexeddb/modern/resources/deleteindex-4.js: (prepareDatabase.tx.onabort): (prepareDatabase.tx.onerror): (prepareDatabase.tx.oncomplete): (finishTest): Deleted. * LayoutTests/storage/indexeddb/modern/resources/double-abort.js: (prepareDatabase.versionTransaction.onabort): (prepareDatabase.versionTransaction.oncomplete): (prepareDatabase.versionTransaction.onerror): (prepareDatabase): (done): Deleted. * LayoutTests/storage/indexeddb/modern/resources/idbdatabase-deleteobjectstore-failures.js: (prepareDatabase.versionTransaction.onabort): (prepareDatabase.versionTransaction.onerror): (prepareDatabase): (continueTest1.transaction.onabort): (continueTest1.transaction.onerror): (continueTest1): (continueTest2.openRequest.onerror): (continueTest2.openRequest.onblocked): (continueTest2.openRequest.onsuccess): (continueTest2.versionTransaction.onabort): (continueTest2.versionTransaction.oncomplete): (continueTest2.versionTransaction.onerror): (continueTest2.openRequest.onupgradeneeded): (continueTest2): (done): Deleted. * LayoutTests/storage/indexeddb/modern/resources/idbdatabase-transaction-failures.js: (prepareDatabase.request.onerror): (prepareDatabase.versionTransaction.onabort): (prepareDatabase.versionTransaction.onerror): (prepareDatabase): (continueTest): (done): Deleted. * LayoutTests/storage/indexeddb/modern/resources/idbtransaction-objectstore-failures.js: (prepareDatabase.tx.onabort): (prepareDatabase.tx.oncomplete): (prepareDatabase.tx.onerror): (prepareDatabase): (done): Deleted. * LayoutTests/storage/indexeddb/modern/resources/index-5.js: (checkIndexValues.cursorRequest.onsuccess): (prepareDatabase.versionTransaction.onabort): (prepareDatabase.versionTransaction.oncomplete): (prepareDatabase.versionTransaction.onerror): (prepareDatabase): (done): Deleted. (log): Deleted. * LayoutTests/storage/indexeddb/modern/resources/transaction-scheduler-1.js: (prepareDatabase.request.onerror): (prepareDatabase.versionTransaction.onabort): (prepareDatabase.versionTransaction.onerror): (prepareDatabase): (request.onerror): (request.onblocked): (request.onupgradeneeded): (setupRequest): (request.onsuccess): (transaction.onerror): (transaction.onabort): (transaction.oncomplete): (startTransactionLoop): (done): Deleted. * LayoutTests/storage/indexeddb/modern/resources/transaction-scheduler-2.js: (prepareDatabase.request.onerror): (prepareDatabase.versionTransaction.onabort): (prepareDatabase.versionTransaction.onerror): (prepareDatabase): (request.onerror): (request.onblocked): (request.onupgradeneeded): (setupRequest): (request.onsuccess): (transaction.onerror): (transaction.onabort): (transaction.oncomplete): (startTransactionLoop): (done): Deleted. * LayoutTests/storage/indexeddb/resources/shared.js: (endTestWithLog): Canonical link: https://commits.webkit.org/293596@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes