Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d547f9c8eae1f21fe1d88d8e86ac19edaa3f2614
https://github.com/WebKit/WebKit/commit/d547f9c8eae1f21fe1d88d8e86ac19edaa3f2614
Author: Alan Baradlay <za...@apple.com>
Date: 2025-04-11 (Fri, 11 Apr 2025)
Changed paths:
A LayoutTests/fast/ruby/sideways-lr-incorrect-position-expected.html
A LayoutTests/fast/ruby/sideways-lr-incorrect-position.html
M Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.cpp
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h
Log Message:
-----------
Incorrect ruby annotation positioning in sideways-lr
https://bugs.webkit.org/show_bug.cgi?id=291177
<rdar://problem/148713073>
Reviewed by Antti Koivisto.
While BoxGeometry is supposed to hold logical geometry, it is a slightly
modified one
where left is visual left (required by render tree integration) which means that
WritingMode::isLineOverLeft needs special handling (also see FIXME comment in
processRubyContent).
* LayoutTests/fast/ruby/sideways-lr-incorrect-position-expected.html: Added.
* LayoutTests/fast/ruby/sideways-lr-incorrect-position.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.cpp:
(WebCore::Layout::shiftDisplayBox):
(WebCore::Layout::expandInlineBox):
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processRubyContent):
(WebCore::Layout::InlineDisplayContentBuilder::flipLogicalRectToVisualForWritingModeWithinLine
const): Deleted.
(WebCore::Layout::InlineDisplayContentBuilder::flipRootInlineBoxRectToVisualForWritingMode
const): Deleted.
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:
(WebCore::Layout::InlineDisplayContentBuilder::mapInlineRectLogicalToVisual):
Canonical link: https://commits.webkit.org/293572@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
