Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1fd4bce096a43e60dc9ecde1743a043bce691dae
      
https://github.com/WebKit/WebKit/commit/1fd4bce096a43e60dc9ecde1743a043bce691dae
  Author: Philippe Normand <ph...@igalia.com>
  Date:   2025-04-11 (Fri, 11 Apr 2025)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
    M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.h

  Log Message:
  -----------
  [GStreamer][WebRTC] Improve support for msid SDP attributes handling
https://bugs.webkit.org/show_bug.cgi?id=291365

Reviewed by Xabier Rodriguez-Calvar.

Our endpoint was generating one msid per payload type in SDP offers, while only 
one per m-line
should be generated. Also when no MediaStream is specified in addTrack() and 
addTransceiver() calls,
a `-` msid should be generated. With this patch almost all tests in
imported/w3c/web-platform-tests/webrtc/protocol/msid-generate.html pass now, 
excepted a couple ones
due to https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3954.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::addTrack):
(WebCore::GStreamerMediaEndpoint::createTransceiverBackends):

Canonical link: https://commits.webkit.org/293569@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to