Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 66f5967f9a53831a66dedc5ef7e8df5c9351350a
https://github.com/WebKit/WebKit/commit/66f5967f9a53831a66dedc5ef7e8df5c9351350a
Author: Alan Baradlay <za...@apple.com>
Date: 2025-04-09 (Wed, 09 Apr 2025)
Changed paths:
A
LayoutTests/fast/inline/absolute-positioned-box-in-continuation-misplaced-expected.html
A
LayoutTests/fast/inline/absolute-positioned-box-in-continuation-misplaced.html
M Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp
Log Message:
-----------
delta.com: Credit Card logo blocks credit card number
https://bugs.webkit.org/show_bug.cgi?id=291308
<rdar://148595445>
Reviewed by Antti Koivisto.
This logic is supposed to append the out-of-flow box to the end of the previous
block in
continuation when the before child is the first child in the current
continuation.
(It is required to be able to compute static position correctly)
However "beforeChild == beforeChildParent.firstChild()" is not sufficient as it
computes to true
for a wide variety of cases where we don't need to move the box.
e.g.
DIV RenderBlock
RenderBlock
SPAN RenderInline (continuation)
#text RenderText
RenderBlock (continuation)
DIV RenderBlock
RenderBlock
SPAN RenderInline (continuation)
where the before child -> RenderText which is also a first child, but not the
type
of first child we are looking for here.
*
LayoutTests/fast/inline/absolute-positioned-box-in-continuation-misplaced-expected.html:
Added.
*
LayoutTests/fast/inline/absolute-positioned-box-in-continuation-misplaced.html:
Added.
* Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp:
(WebCore::RenderTreeBuilder::Inline::insertChildToContinuation):
Canonical link: https://commits.webkit.org/293478@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
