Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 35a47bb89d44e6447fd451cbd7d4fd0956a646a9
https://github.com/WebKit/WebKit/commit/35a47bb89d44e6447fd451cbd7d4fd0956a646a9
Author: Marcus Plutowski <marcus_plutow...@apple.com>
Date: 2025-04-09 (Wed, 09 Apr 2025)
Changed paths:
M Source/bmalloc/libpas/src/libpas/bmalloc_heap_config.h
M Source/bmalloc/libpas/src/libpas/hotbit_heap_config.h
M Source/bmalloc/libpas/src/libpas/iso_heap_config.h
M Source/bmalloc/libpas/src/libpas/iso_test_heap_config.h
M Source/bmalloc/libpas/src/libpas/jit_heap_config.h
M Source/bmalloc/libpas/src/libpas/minalign32_heap_config.h
M Source/bmalloc/libpas/src/libpas/pagesize64k_heap_config.h
M Source/bmalloc/libpas/src/libpas/pas_heap_config_utils.h
M Source/bmalloc/libpas/src/libpas/pas_internal_config.h
M Source/bmalloc/libpas/src/libpas/pas_local_allocator_inlines.h
M Source/bmalloc/libpas/src/libpas/pas_segregated_page_config.h
M Source/bmalloc/libpas/src/libpas/pas_segregated_shared_view.h
M Source/bmalloc/libpas/src/libpas/pas_utility_heap_config.h
M Source/bmalloc/libpas/src/libpas/thingy_heap_config.h
Log Message:
-----------
[libpas] Add padding between partial-views within a segregated page
https://bugs.webkit.org/show_bug.cgi?id=291240
rdar://148783142
Reviewed by David Degazio.
Segregated pages allocate partial views out of shared views. This is the
only thing we ever bump shared views for -- which, beyond the fact that
that's the only reason we *currently* bump shared views for, is
evidenced by how sharing_shift (which expands the allocation to include
more than just one object-slot) is *always* used inside
pas_segregated_shared_view_compute_new_bump.
Hardcoding this padding as a global constant would have reduced the
runtime performance overhead at least slightly, but at the cost of
additional space usage because it would no longer be possible to
differentiate between different heap types (e.g. utility vs. bmalloc)
or small and medium pages within a heap -- at least without manually
checking, which would just reintroduce this overhead.
* Source/bmalloc/libpas/src/libpas/bmalloc_heap_config.h:
* Source/bmalloc/libpas/src/libpas/hotbit_heap_config.h:
* Source/bmalloc/libpas/src/libpas/iso_heap_config.h:
* Source/bmalloc/libpas/src/libpas/iso_test_heap_config.h:
* Source/bmalloc/libpas/src/libpas/jit_heap_config.h:
* Source/bmalloc/libpas/src/libpas/minalign32_heap_config.h:
* Source/bmalloc/libpas/src/libpas/pagesize64k_heap_config.h:
* Source/bmalloc/libpas/src/libpas/pas_heap_config_utils.h:
* Source/bmalloc/libpas/src/libpas/pas_internal_config.h:
* Source/bmalloc/libpas/src/libpas/pas_local_allocator_inlines.h:
(pas_local_allocator_start_allocating_in_primordial_partial_view):
* Source/bmalloc/libpas/src/libpas/pas_segregated_page_config.h:
* Source/bmalloc/libpas/src/libpas/pas_segregated_shared_view.h:
(pas_segregated_shared_view_compute_minimum_size_for_bump_with_aligned_padding):
(pas_segregated_shared_view_compute_new_bump):
(pas_segregated_shared_view_compute_minimum_size_for_bump):
* Source/bmalloc/libpas/src/libpas/pas_utility_heap_config.h:
* Source/bmalloc/libpas/src/libpas/thingy_heap_config.h:
Canonical link: https://commits.webkit.org/293476@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
