Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46ebeb960729df7e3c2072e74ae7d82dad19a48f
      
https://github.com/WebKit/WebKit/commit/46ebeb960729df7e3c2072e74ae7d82dad19a48f
  Author: Pedro Varangot <pvaran...@apple.com>
  Date:   2025-04-04 (Fri, 04 Apr 2025)

  Changed paths:
    A 
LayoutTests/fast/dom/skipviewtransition-callback-with-no-globalobject-expected.txt
    A LayoutTests/fast/dom/skipviewtransition-callback-with-no-globalobject.html
    M Source/WebCore/dom/ViewTransition.cpp

  Log Message:
  -----------
  When skipping a ViewTransition the global object can be null. That results in 
a crash when trying to call the update callback.
https://bugs.webkit.org/show_bug.cgi?id=290930
rdar://147936177

Reviewed by Ryosuke Niwa.

This fixes the issue by checking that the global object on the document
is not null before calling the callback that updates the DOM.

* 
LayoutTests/fast/dom/skipviewtransition-callback-with-no-globalobject-expected.txt:
 Added.
* LayoutTests/fast/dom/skipviewtransition-callback-with-no-globalobject.html: 
Added.
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::skipViewTransition):

Canonical link: https://commits.webkit.org/293262@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to