Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a69566e95b0cf542c4a915531b822c1afab5eb78
https://github.com/WebKit/WebKit/commit/a69566e95b0cf542c4a915531b822c1afab5eb78
Author: Mike Wyrzykowski <mwyrzykow...@apple.com>
Date: 2025-04-01 (Tue, 01 Apr 2025)
Changed paths:
A LayoutTests/fast/webgpu/nocrash/fuzz-290831-expected.txt
A LayoutTests/fast/webgpu/nocrash/fuzz-290831.html
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
Log Message:
-----------
[WebGPU] Passing large structures by value can trigger MTLCompiler crashes
https://bugs.webkit.org/show_bug.cgi?id=290831
rdar://146794909
Reviewed by Tadeu Zagallo.
Metal compiler crashes were observed passing large types by value
to __pack() and __unpack(). Avoid this by inlining so we don't need
to generate multiple functions for different address space variants.
* LayoutTests/fast/webgpu/nocrash/fuzz-290831-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-290831.html: Added.
Add regression tests.
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::emitNecessaryHelpers):
(WGSL::Metal::FunctionDefinitionWriter::generatePackingHelpers):
Inline the functions so large values aren't passed by value.
Canonical link: https://commits.webkit.org/293029@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
