[webkit-changes] [WebKit/WebKit] 6b4b15: Use WebProcessProxy::fromConnection instead of Web...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6b4b15e862c9ae56350f18545b7e9e66e9727b1f
      
https://github.com/WebKit/WebKit/commit/6b4b15e862c9ae56350f18545b7e9e66e9727b1f
  Author: Alex Christensen <achristen...@apple.com>
  Date:   2025-04-03 (Thu, 03 Apr 2025)

  Changed paths:
    M 
Source/WebKit/Scripts/PreferencesTemplates/SharedPreferencesForWebProcess.h.erb
    M 
Source/WebKit/Scripts/PreferencesTemplates/SharedPreferencesForWebProcess.serialization.in.erb
    M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h
    M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.messages.in
    M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm
    M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.h
    M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.messages.in
    M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm
    M Source/WebKit/UIProcess/Media/RemoteMediaSessionCoordinatorProxy.cpp
    M Source/WebKit/UIProcess/Media/RemoteMediaSessionCoordinatorProxy.h
    M 
Source/WebKit/UIProcess/Media/RemoteMediaSessionCoordinatorProxy.messages.in
    M Source/WebKit/UIProcess/WebProcessProxy.h
    M Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.cpp
    M Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.h
    M Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.messages.in
    M Source/WebKit/UIProcess/XR/PlatformXRSystem.cpp
    M Source/WebKit/UIProcess/XR/PlatformXRSystem.h
    M Source/WebKit/UIProcess/XR/PlatformXRSystem.messages.in
    M Source/WebKit/UIProcess/ios/WebDeviceOrientationUpdateProviderProxy.h
    M 
Source/WebKit/UIProcess/ios/WebDeviceOrientationUpdateProviderProxy.messages.in
    M Source/WebKit/UIProcess/ios/WebDeviceOrientationUpdateProviderProxy.mm

  Log Message:
  -----------
  Use WebProcessProxy::fromConnection instead of 
WebPageProxy::legacyMainFrameProcess to get SharedPreferencesForWebProcess
https://bugs.webkit.org/show_bug.cgi?id=291020
rdar://148547675

Reviewed by Sihui Liu.

This will get us the correct value when site isolation is on.
Also use bit fields to greatly reduce sizeof(SharedPreferencesForWebProcess)
And reduce copies a bit by making 
WebProcessProxy::sharedPreferencesForWebProcessValue
return by reference instead of by value.

* 
Source/WebKit/Scripts/PreferencesTemplates/SharedPreferencesForWebProcess.h.erb:
* 
Source/WebKit/Scripts/PreferencesTemplates/SharedPreferencesForWebProcess.serialization.in.erb:
* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.messages.in:
* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:
(WebKit::PlaybackSessionManagerProxy::sharedPreferencesForWebProcess const):
* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.messages.in:
* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm:
(WebKit::VideoPresentationManagerProxy::sharedPreferencesForWebProcess const):
* Source/WebKit/UIProcess/Media/RemoteMediaSessionCoordinatorProxy.cpp:
(WebKit::RemoteMediaSessionCoordinatorProxy::sharedPreferencesForWebProcess 
const):
* Source/WebKit/UIProcess/Media/RemoteMediaSessionCoordinatorProxy.h:
* Source/WebKit/UIProcess/Media/RemoteMediaSessionCoordinatorProxy.messages.in:
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.cpp:
(WebKit::WebScreenOrientationManagerProxy::sharedPreferencesForWebProcess 
const):
* Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.h:
* Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.messages.in:
* Source/WebKit/UIProcess/XR/PlatformXRSystem.cpp:
(WebKit::PlatformXRSystem::sharedPreferencesForWebProcess const):
* Source/WebKit/UIProcess/XR/PlatformXRSystem.h:
* Source/WebKit/UIProcess/XR/PlatformXRSystem.messages.in:
* Source/WebKit/UIProcess/ios/WebDeviceOrientationUpdateProviderProxy.h:
* 
Source/WebKit/UIProcess/ios/WebDeviceOrientationUpdateProviderProxy.messages.in:
* Source/WebKit/UIProcess/ios/WebDeviceOrientationUpdateProviderProxy.mm:
(WebKit::WebDeviceOrientationUpdateProviderProxy::sharedPreferencesForWebProcess
 const):

Canonical link: https://commits.webkit.org/293211@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes