Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 27cdd2696cac96e278f244f3594911fbc5766554
      
https://github.com/WebKit/WebKit/commit/27cdd2696cac96e278f244f3594911fbc5766554
  Author: Kiet Ho <kiet...@apple.com>
  Date:   2025-03-31 (Mon, 31 Mar 2025)

  Changed paths:
    A LayoutTests/fast/css/css-anchor-position/anchor-page-zoom-expected.html
    A LayoutTests/fast/css/css-anchor-position/anchor-page-zoom.html
    A 
LayoutTests/fast/css/css-anchor-position/anchor-size-page-zoom-expected.html
    A LayoutTests/fast/css/css-anchor-position/anchor-size-page-zoom.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-css-zoom-expected.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-css-zoom.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-size-css-zoom-expected.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-size-css-zoom.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/reference/anchor-css-zoom-ref.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/reference/anchor-size-css-zoom-ref.html
    M Source/WebCore/style/AnchorPositionEvaluator.cpp

  Log Message:
  -----------
  [css-anchor-position-1] Adjust anchor()/anchor-size() for viewport and CSS 
zoom
rdar://146806814
https://bugs.webkit.org/show_bug.cgi?id=289578

Reviewed by Antti Koivisto.

The value returned by anchor()/anchor-size() is calculated at 1x viewport zoom,
which is wrong if either:
* the viewport is zoomed using Ctrl+/Ctrl-, or
* CSS zoom property is used.

This patch fixes this by adjusting the returned value by the zoom factor.

* LayoutTests/fast/css/css-anchor-position/anchor-page-zoom-expected.html: 
Added.
* LayoutTests/fast/css/css-anchor-position/anchor-page-zoom.html: Added.
    - Added test for anchor() + viewport zoom. This test can't be added to WPT,
      as WPT does not support changing viewport zoom factor.

* LayoutTests/fast/css/css-anchor-position/anchor-size-page-zoom-expected.html: 
Added.
* LayoutTests/fast/css/css-anchor-position/anchor-size-page-zoom.html: Added.
    - Added test for anchor-size() + viewport zoom. This test can't be added to 
WPT,
      as WPT does not support changing viewport zoom factor.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-css-zoom-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-css-zoom.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/reference/anchor-css-zoom-ref.html:
 Added.
    - Added test for anchor() + CSS zoom.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-size-css-zoom-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-size-css-zoom.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/reference/anchor-size-css-zoom-ref.html:
 Added.
    - Added test for anchor-size() + CSS zoom.

* Source/WebCore/style/AnchorPositionEvaluator.cpp:
(WebCore::Style::AnchorPositionEvaluator::evaluate):
(WebCore::Style::AnchorPositionEvaluator::evaluateSize):

Canonical link: https://commits.webkit.org/292985@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to