Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4e6dec1c3f8e540bd1cd967dbf937cde961748e9
https://github.com/WebKit/WebKit/commit/4e6dec1c3f8e540bd1cd967dbf937cde961748e9
Author: Keith Miller <keith_mil...@apple.com>
Date: 2025-03-31 (Mon, 31 Mar 2025)
Changed paths:
M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp
M Source/JavaScriptCore/wasm/WasmBBQJIT.h
Log Message:
-----------
REGRESSION(292808@main?)[Win] RELEASE_ASSERT_NOT_REACHED fails in
JSC::Wasm::BBQJITImpl::BBQJIT::RegisterBinding::toValue() for
workers/worker-to-worker.html
https://bugs.webkit.org/show_bug.cgi?id=290650
rdar://148248212
Reviewed by Yusuke Suzuki.
RegisterBinding was using a bitfield to pack its members. On Windows this
bitfield wasn't bitfielding (packing) properly. So
the other 32-bit union member used to initialize everything at once didn't
initialize all the members. This patch
fixes this by removing the union and default initializing each of the fields.
Clang/GCC are smart enough to convert
these into a single zero store anyway. Also, move some code to the header so it
can be inlined more.
* LayoutTests/workers/wasm-references/test.js:
(runTest):
(runTest.worker.onmessage): Deleted.
(doGC): Deleted.
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJITImpl::RegisterBinding::dump const):
(JSC::Wasm::BBQJITImpl::BBQJIT::willParseOpcode):
* Source/JavaScriptCore/wasm/WasmBBQJIT.h:
* Source/JavaScriptCore/wasm/WasmFunctionParser.h:
Canonical link: https://commits.webkit.org/292958@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
