Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f122d5f024618b02a9c63c3c87578ad65262363
      
https://github.com/WebKit/WebKit/commit/0f122d5f024618b02a9c63c3c87578ad65262363
  Author: Andy Estes <aes...@apple.com>
  Date:   2025-03-27 (Thu, 27 Mar 2025)

  Changed paths:
    M 
Source/WebCore/Modules/modern-media-controls/controls/tvos-media-controls.js

  Log Message:
  -----------
  On some websites, toggling built-in media controls visibility also toggles 
video playback
https://bugs.webkit.org/show_bug.cgi?id=290431
rdar://147885986

Reviewed by Jer Noble and Ryosuke Niwa.

When built-in media controls are visible, some MediaControls subclasses add 
event listeners for
click-related events and stop propagation so that clicks intended to show/hide 
the media controls
do not propagate to the underlying webpage. However, touch events were not 
included in the list of
non-propagating events. Some websites play/pause videos in response to touch 
events, so by allowing
these events to propagate, tapping to show/hide the built-in media controls has 
the side effect of
also playing/pausing the video. Resolved this by including "touchstart" and 
"touchend" in the list
of events for which we stop propagation.

* Source/WebCore/Modules/modern-media-controls/controls/tvos-media-controls.js:

Canonical link: https://commits.webkit.org/292763@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to