Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9fddc271aaad0f6c65417976e2b93dae2ac3e752
https://github.com/WebKit/WebKit/commit/9fddc271aaad0f6c65417976e2b93dae2ac3e752
Author: Tadeu Zagallo <tzaga...@apple.com>
Date: 2025-03-27 (Thu, 27 Mar 2025)
Changed paths:
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
A Source/WebGPU/WGSL/tests/valid/packing-pointer-arguments.wgsl
Log Message:
-----------
[WGSL] Pointer are incorrectly packed/unpacked
https://bugs.webkit.org/show_bug.cgi?id=290425
rdar://147751610
Reviewed by Mike Wyrzykowski.
Pointers have to be handled slightly different from other types, since we can't
unpack pointers to packed types, so we have to skip any packing/unpacking for
pointer types. We also have to handle dereferencing differently from most other
operations, since pointers are special-cased we have to ignore the packing of
the target and return the packing for the dereferencing result instead.
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::getPacking):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::emitPackedVector):
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/tests/valid/packing-pointer-arguments.wgsl: Added.
Canonical link: https://commits.webkit.org/292751@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
