Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e48690b09468f9a19bbc3aeeb5d2c38a3d279984
https://github.com/WebKit/WebKit/commit/e48690b09468f9a19bbc3aeeb5d2c38a3d279984
Author: Fujii Hironori <hironori.fu...@sony.com>
Date: 2025-03-26 (Wed, 26 Mar 2025)
Changed paths:
M Source/JavaScriptCore/assembler/LinkBuffer.cpp
M Source/JavaScriptCore/assembler/PerfLog.cpp
M Source/JavaScriptCore/assembler/PerfLog.h
Log Message:
-----------
[JSC][Win][Clang 20] LinkBuffer.h: warning: private field 'm_ownerUID' is not
used [-Wunused-private-field]
https://bugs.webkit.org/show_bug.cgi?id=290355
Reviewed by Yusuke Suzuki.
clang-cl v20.1 emitted unused-private-field warnings for m_ownerUID
and m_isRewriting of LinkBuffer class for Windows port. Those fields
were only used for OS(LINUX) || OS(DARWIN) because PerfLog class
supported only the platforms. PerfLog supports only ELF format.
This problem could be worked around by conditioning out the fields in
LinkBuffer class for Windows. However, it will introduce more #if
directives in the class.
Rather than doing that, this change makes PerfLog class to be able to
compile for Windows with less platform-specific #if directives. This
change doesn't make PerfLog class usable nor enable
JSC_logJITCodeForPerf option for Windows. Options::isAvailable enables
it only for OS(LINUX) || OS(DARWIN) at the moment.
* Source/JavaScriptCore/assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::logJITCodeForPerf):
* Source/JavaScriptCore/assembler/PerfLog.cpp:
(JSC::getCurrentThreadID):
(JSC::PerfLog::PerfLog):
* Source/JavaScriptCore/assembler/PerfLog.h:
Canonical link: https://commits.webkit.org/292740@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
