Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f4cc960998d97ca6fcd57602e98562abc35679b8
https://github.com/WebKit/WebKit/commit/f4cc960998d97ca6fcd57602e98562abc35679b8
Author: Timothy Hatcher <[email protected]>
Date: 2025-03-21 (Fri, 21 Mar 2025)
Changed paths:
M
Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionDynamicScriptsCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm
Log Message:
-----------
Crash after calling browser.scripting.updateContentScripts().
https://webkit.org/b/290140
rdar://146812539
Reviewed by Brian Weinstein.
We were accessing a std::optional without checking if it has a value first.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionDynamicScriptsCocoa.mm:
(WebKit::WebExtensionDynamicScripts::WebExtensionRegisteredScript::merge):
Always check the optionals before
accessing the value.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIScripting,
UpdateContentScriptsWithMinimalParametersShouldNotCrash)): Added.
Canonical link: https://commits.webkit.org/292487@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
