Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: daaa90772fea480a4f5a3c8e2d14c7fe78c8f2de
https://github.com/WebKit/WebKit/commit/daaa90772fea480a4f5a3c8e2d14c7fe78c8f2de
Author: Alex Christensen <achristen...@apple.com>
Date: 2025-03-19 (Wed, 19 Mar 2025)
Changed paths:
A
LayoutTests/fullscreen/fullscreen-restore-scroll-position-with-scroll-during-enter-expected.txt
A
LayoutTests/fullscreen/fullscreen-restore-scroll-position-with-scroll-during-enter.html
M Source/WebKit/UIProcess/API/C/WKPage.cpp
M Source/WebKit/UIProcess/API/C/WKPageFullScreenClient.h
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
M Tools/WebKitTestRunner/TestController.cpp
M Tools/WebKitTestRunner/TestController.h
M Tools/WebKitTestRunner/TestInvocation.cpp
Log Message:
-----------
Save scroll position before sending
Messages::WebFullScreenManagerProxy::EnterFullScreen
https://bugs.webkit.org/show_bug.cgi?id=290068
rdar://147242681
Reviewed by Simon Fraser.
In 290276@main I simplified the IPC, but especially on iOS things can change
between the message
being sent and the reply being received. I verified that saving the scroll
position before it changes
fixes the issue, and fullscreen/fullscreen-restore-scroll-position.html still
passes.
I also modified the test fullscreen/fullscreen-restore-scroll-position.html to
scroll during entering
fullscreen to make the test cover this change.
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::enterFullScreenForElement):
Canonical link: https://commits.webkit.org/292402@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
