Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e3c2535633433955eec4f91c2d5380b4d8b6f2de
https://github.com/WebKit/WebKit/commit/e3c2535633433955eec4f91c2d5380b4d8b6f2de
Author: Alex Christensen <achristen...@apple.com>
Date: 2025-03-13 (Thu, 13 Mar 2025)
Changed paths:
M Source/JavaScriptCore/API/JSValue.mm
M Source/WebKit/Shared/JavaScriptEvaluationResult.h
M Source/WebKit/Shared/JavaScriptEvaluationResult.mm
Log Message:
-----------
REGRESSION(291600@main-291601@main): [ Debug ]
TestWebKitAPI.AdvancedPrivacyProtections.VerifyPixelsFromNoisyCanvas2DAPI is a
constant timeout
https://bugs.webkit.org/show_bug.cgi?id=289478
rdar://146674117
Reviewed by Sihui Liu.
We had an extra transformation step between JS evaluation and UI process ObjC
result instantiation.
This test took almost 30 seconds in debug, and the extra transformation step
made it take a little
additional time, causing it to time out pretty reliably. This perf
optimization removes a step,
making it faster.
* Source/JavaScriptCore/API/JSValue.mm:
* Source/WebKit/Shared/JavaScriptEvaluationResult.h:
* Source/WebKit/Shared/JavaScriptEvaluationResult.mm:
(WebKit::JavaScriptEvaluationResult::toVariant):
(WebKit::JavaScriptEvaluationResult::addObjectToMap):
(WebKit::JavaScriptEvaluationResult::JavaScriptEvaluationResult):
(WebKit::convertToObjC): Deleted.
Canonical link: https://commits.webkit.org/292139@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
