Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 89f7b2a233dfec9a45474995c4c2a209b4e702fe
https://github.com/WebKit/WebKit/commit/89f7b2a233dfec9a45474995c4c2a209b4e702fe
Author: BJ Burg <[email protected]>
Date: 2025-03-13 (Thu, 13 Mar 2025)
Changed paths:
M
Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py
A
Source/JavaScriptCore/inspector/scripts/tests/expected/fail-on-invalid-json-with-context.json-error
A
Source/JavaScriptCore/inspector/scripts/tests/fail-on-invalid-json-with-context.json
M Tools/Scripts/webkitpy/style/checker.py
Log Message:
-----------
Web Inspector: improve error message when code generator is unable to parse
JSON
https://bugs.webkit.org/show_bug.cgi?id=289613
Reviewed by Devin Rousso.
Having the error context readily available makes it much easier to edit
protocol JSON files.
*
Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:
(generate_from_specification.load_specification): Save the filename so it can
be used later in
the topmost exception handler to create a nice error message. Print the error
message to stderr
so that failure results can be correctly interpreted by
`run-inspector-generator-tests --reset-results`.
*
Source/JavaScriptCore/inspector/scripts/tests/expected/fail-on-invalid-json-with-context.json-error:
Added.
*
Source/JavaScriptCore/inspector/scripts/tests/fail-on-invalid-json-with-context.json:
Added.
* Tools/Scripts/webkitpy/style/checker.py:
Skip checking of JSON syntax in the Inspector code generator tests directory.
We intentionally
use some invalid JSON inputs starting with this change.
Canonical link: https://commits.webkit.org/292123@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
