Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a7ab3a372a52e60a9a0618bbd5148aa1bc21ec01
      
https://github.com/WebKit/WebKit/commit/a7ab3a372a52e60a9a0618bbd5148aa1bc21ec01
  Author: Alex Christensen <achristen...@apple.com>
  Date:   2025-03-13 (Thu, 13 Mar 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/APINavigation.cpp
    M Source/WebKit/UIProcess/API/APINavigation.h
    M Source/WebKit/UIProcess/API/Cocoa/WKNavigationAction.mm
    M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  API::Navigation::m_lastNavigationAction should be optional
https://bugs.webkit.org/show_bug.cgi?id=289646
rdar://146890518

Reviewed by Brady Eidson.

This is conceptually correct.  If it hasn't been set, then we
don't have a last navigation action.  This is also a step towards
making FrameInfoData have no default constructor.

* Source/WebKit/UIProcess/API/APINavigation.cpp:
(API::Navigation::currentRequestIsCrossSiteRedirect const):
* Source/WebKit/UIProcess/API/APINavigation.h:
(API::Navigation::currentRequestIsRedirect const):
(API::Navigation::wasUserInitiated const):
(API::Navigation::isRequestFromClientOrUserInput const):
(API::Navigation::markRequestAsFromClientInput):
(API::Navigation::shouldPerformDownload const):
(API::Navigation::treatAsSameOriginNavigation const):
(API::Navigation::hasOpenedFrames const):
(API::Navigation::openedByDOMWithOpener const):
(API::Navigation::isInitialFrameSrcLoad const):
(API::Navigation::requesterOrigin const):
(API::Navigation::shouldOpenExternalURLsPolicy const):
(API::Navigation::lockHistory const):
(API::Navigation::lockBackForwardList const):
(API::Navigation::clientRedirectSourceForHistory const):
(API::Navigation::ownerPermissionsPolicy const):
(API::Navigation::lastNavigationAction const):
(API::Navigation::privateClickMeasurement const):
* Source/WebKit/UIProcess/API/Cocoa/WKNavigationAction.mm:
(-[WKNavigationAction _storeSKAdNetworkAttribution]):
* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::loadData):
(WebKit::ProvisionalPageProxy::loadRequest):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):

Canonical link: https://commits.webkit.org/292096@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to