Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3678d3f1bb37bdddc20b8843f0e1a995617c64d6
https://github.com/WebKit/WebKit/commit/3678d3f1bb37bdddc20b8843f0e1a995617c64d6
Author: Alex Christensen <achristen...@apple.com>
Date: 2025-03-12 (Wed, 12 Mar 2025)
Changed paths:
M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h
M Tools/WebKitTestRunner/Options.cpp
M Tools/WebKitTestRunner/StringFunctions.h
M Tools/WebKitTestRunner/TestController.cpp
M Tools/WebKitTestRunner/TestController.h
Log Message:
-----------
Move WebKitTestRunner alert, prompt, and confirm output from injected bundle
to UI process
https://bugs.webkit.org/show_bug.cgi?id=289581
Reviewed by Pascoe.
This is needed for site isolation, where alerts may be coming from different
processes.
This also tests functionality that is closer to what WKWebView does. The
alert, prompt,
and confirm functions already send a synchronous message.
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::willRunJavaScriptAlert): Deleted.
(WTR::InjectedBundlePage::willRunJavaScriptConfirm): Deleted.
(WTR::InjectedBundlePage::willRunJavaScriptPrompt): Deleted.
(WTR::stripTrailingSpacesAddNewline): Deleted.
(WTR::addLeadingSpaceStripTrailingSpacesAddNewline): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
* Tools/WebKitTestRunner/Options.cpp:
(WTR::parseFeature):
* Tools/WebKitTestRunner/StringFunctions.h:
(WTR::split):
(WTR::stripTrailingSpacesAddNewline):
(WTR::addLeadingSpaceStripTrailingSpacesAddNewline):
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::runJavaScriptAlert):
(WTR::runJavaScriptPrompt):
(WTR::runJavaScriptConfirm):
(WTR::TestController::createOtherPlatformWebView):
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::handleJavaScriptAlert):
(WTR::TestController::handleJavaScriptPrompt):
(WTR::TestController::handleJavaScriptConfirm):
* Tools/WebKitTestRunner/TestController.h:
Canonical link: https://commits.webkit.org/292030@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
