Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: adbacc406e959ee3ade17bdd33889b51f9dd7d19 https://github.com/WebKit/WebKit/commit/adbacc406e959ee3ade17bdd33889b51f9dd7d19 Author: Alex Christensen <achristen...@apple.com> Date: 2025-03-11 (Tue, 11 Mar 2025)
Changed paths: M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h M Source/WebKit/Shared/JavaScriptEvaluationResult.mm M Source/WebKit/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm M Tools/TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm Log Message: ----------- Revert 291895@main https://bugs.webkit.org/show_bug.cgi?id=289568 rdar://146796132 Unreviewed. Returning DOM nodes is not such a great idea after all. Going to example.com and evaluating the JS string @"document" caused a dictionary with over 27000 nodes to be returned. The filtering aspect of the SerializedScriptValue roundtrip is actually desirable. The null check in JSContainerConvertor::convert was necessary. I'm leaving that. * Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h: * Source/WebKit/Shared/JavaScriptEvaluationResult.mm: (WebKit::JavaScriptEvaluationResult::extract): * Tools/TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp: (TestWebKitAPI::didCreateBlob): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm: (TEST(WKWebView, EvaluateJavaScriptErrorCases)): (ReturnTypes)): Canonical link: https://commits.webkit.org/291986@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes