Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5b0f914d1fa281421d2e6e93917e6760af113cbd
      
https://github.com/WebKit/WebKit/commit/5b0f914d1fa281421d2e6e93917e6760af113cbd
  Author: Alex Christensen <achristen...@apple.com>
  Date:   2025-03-10 (Mon, 10 Mar 2025)

  Changed paths:
    M Source/JavaScriptCore/API/JSValue.mm
    M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
    M Source/WebKit/Shared/JavaScriptEvaluationResult.mm
    M Tools/TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm

  Log Message:
  -----------
  Re-land 291425@main
https://bugs.webkit.org/show_bug.cgi?id=289410
rdar://146563641

Reviewed by Sihui Liu.

The tests found a missing null check in JSContainerConvertor::convert so it was 
reverted in 291600@main.
This redoes it and adds the null check.  Covered by API tests 
TestWebKitAPI.WebKit.FindTextInImageOverlay
and TestWebKitAPI.ResourceLoadStatistics.StorageAccessPromptSiteWithTrigger.

* Source/JavaScriptCore/API/JSValue.mm:
(JSContainerConvertor::convert):
* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebKit/Shared/JavaScriptEvaluationResult.mm:
(WebKit::JavaScriptEvaluationResult::extract):
* Tools/TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
(TestWebKitAPI::didCreateBlob):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
(TEST(WKWebView, EvaluateJavaScriptErrorCases)):
(ReturnTypes)):

Canonical link: https://commits.webkit.org/291895@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to