Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c5c94552b8654db52263bf89ede8b26b50a6617a
      
https://github.com/WebKit/WebKit/commit/c5c94552b8654db52263bf89ede8b26b50a6617a
  Author: Alex Christensen <achristen...@apple.com>
  Date:   2025-03-10 (Mon, 10 Mar 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/C/WKPage.cpp
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
    M 
Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  -----------
  Don't serialize a JS evaluation result if it won't be used by UI process
https://bugs.webkit.org/show_bug.cgi?id=289412
rdar://146572381

Reviewed by Sihui Liu.

WKWebView.evaluateJavaScript and callAsyncJavaScript have nullable completion 
handlers.
As a performance optimization, if there is no completion handler, skip the 
expensive operation
of collecting, serializing, deserializing, and converting the result to an ObjC 
type just
to discard it.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView 
_evaluateJavaScript:asAsyncFunction:withSourceURL:withArguments:forceUserGesture:inFrame:inWorld:completionHandler:]):
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewRunJavaScriptWithParams):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::runJavaScriptInFrameInScriptWorld):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScript):
(WebKit::WebPage::runJavaScriptInFrameInScriptWorld):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/291896@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to