Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d6dbe62c08c17b5174af025d2695a0e3ad0a3e43
      
https://github.com/WebKit/WebKit/commit/d6dbe62c08c17b5174af025d2695a0e3ad0a3e43
  Author: Alex Christensen <achristen...@apple.com>
  Date:   2025-03-10 (Mon, 10 Mar 2025)

  Changed paths:
    M Source/WebCore/contentextensions/URLFilterParser.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm

  Log Message:
  -----------
  Don't assume character is ASCII in PatternParser::atomCharacterClassAtom
https://bugs.webkit.org/show_bug.cgi?id=289496
rdar://146696055

Reviewed by Pascoe and Timothy Hatcher.

With enough escaping you can get YARR to put a non-ASCII character into that 
function
from ASCII escape characters.  If this happens, fail with the non-ASCII failure 
instead
of asserting.  The resulting regex will be run on a canonicalized URL, which is 
why
we already had an error code for non-ASCII regexes, which are never needed.

* Source/WebCore/contentextensions/URLFilterParser.cpp:
(WebCore::ContentExtensions::PatternParser::atomCharacterClassAtom):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
(TEST_F(WKContentRuleListStoreTest, NonASCIIEscaped)):

Canonical link: https://commits.webkit.org/291938@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to