Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 46b45c86813860a99b3d6abf585b387ba3414a63
https://github.com/WebKit/WebKit/commit/46b45c86813860a99b3d6abf585b387ba3414a63
Author: Lily Spiniolas <lily_spinio...@apple.com>
Date: 2025-03-10 (Mon, 10 Mar 2025)
Changed paths:
M Source/WebCore/rendering/TextPaintStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/rendering/style/RenderStyleSetters.h
M Source/WebCore/rendering/style/StyleRareInheritedData.cpp
M Source/WebCore/rendering/style/StyleRareInheritedData.h
Log Message:
-----------
Add text color filter for inactive windows
https://bugs.webkit.org/show_bug.cgi?id=289364
rdar://146511450
Reviewed by Aditya Keerthi, Wenson Hsieh, and Abrar Rahman Protyasha.
Added a new rare inherited RenderStyle flag with the purpose of
filtering text color during the computation of text paint styles.
`TextPaintStyle::computeTextPaintStyle` now checks for the flag
and inverts the text color if the window is inactive and
light-appearance is used. Additionally, the preexisting flag
`insideDefaultButton` has been moved to rare inherited data since
it is not commonly used.
* Source/WebCore/rendering/TextPaintStyle.cpp:
(WebCore::computeTextPaintStyle):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::rareInheritedDataChangeRequiresRepaint):
(WebCore::RenderStyle::changeRequiresRepaint const):
(WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const):
(WebCore::RenderStyle::InheritedFlags::dumpDifferences const):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::insideDefaultButton const):
(WebCore::RenderStyle::shouldApplyColorFilterWhenInactive const):
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setInsideDefaultButton):
(WebCore::RenderStyle::setShouldApplyColorFilterWhenInactive):
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):
(WebCore::StyleRareInheritedData::dumpDifferences const):
* Source/WebCore/rendering/style/StyleRareInheritedData.h:
Canonical link: https://commits.webkit.org/291934@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
