Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3a96871dc768f7bbdac2dc5837014c6622d006df
      
https://github.com/WebKit/WebKit/commit/3a96871dc768f7bbdac2dc5837014c6622d006df
  Author: Vitor Roriz <vitor.ro...@apple.com>
  Date:   2025-03-09 (Sun, 09 Mar 2025)

  Changed paths:
    M 
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
    M Source/WebCore/css/CSSFontFace.cpp

  Log Message:
  -----------
  CSSFontFace: Fix uncounted lambda captures failures for Safer C++
rdar://146429578
https://bugs.webkit.org/show_bug.cgi?id=289292

Reviewed by Chris Dumez.

1. We are marking the callback for iterateClients as NOESCAPE
as they are not stored/called async. We are adapting redefining
the type of accepted callback as NOESCAPE can only decorate
pointer aguments, in this case a function pointer.

Given that, the lambdas used as callback capture 'this' but this should be fine
as the callbacks are not called async.

2. angleAtIndex: needs to protected pointer to CSSFontStyleRangeValue when 
capturing it.

* 
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations:
* Source/WebCore/css/CSSFontFace.cpp:
(WebCore::iterateClients):
(WebCore::calculateItalicRange):

Canonical link: https://commits.webkit.org/291864@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to