Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 76584d15da2cb59da82653554d4b9c7e446923da
https://github.com/WebKit/WebKit/commit/76584d15da2cb59da82653554d4b9c7e446923da
Author: Joshua Hoffman <jhoffma...@apple.com>
Date: 2025-03-07 (Fri, 07 Mar 2025)
Changed paths:
M Source/WebCore/accessibility/AXTextRun.cpp
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
Log Message:
-----------
AX: [AX Thread Text Marker] Width of bounds returned from bounds for range
grows as you move away from the origin
https://bugs.webkit.org/show_bug.cgi?id=289301
rdar://146436778
Reviewed by Tyler Wilcock.
When calculating the bounds for range API with the new AX thread text markers,
we would pass in the location + the
length of the range to `nextMarkerFromOffset`. However, this assumes that
`nextMarkerForOffset` will be starting
from a 0 offset, rather than the current text marker's offset.
This can result in text marker ranges that are much longer than expected, as
they are adding the location part
of the range unnecessarily. Removing the `range.location` from this callsite
fixes this behavior.
This PR also includes downgraded release asserts in `AXTextRun` to match
291629@main.
* Source/WebCore/accessibility/AXTextRun.cpp:
(WebCore::AXTextRuns::substring const):
(WebCore::AXTextRuns::domOffset const):
(WebCore::AXTextRuns::localRect const):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
Canonical link: https://commits.webkit.org/291773@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
