Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a79e846652fd06c8bf468ca2a79bd65dfc02ea0c
https://github.com/WebKit/WebKit/commit/a79e846652fd06c8bf468ca2a79bd65dfc02ea0c
Author: Alan Baradlay <za...@apple.com>
Date: 2025-03-05 (Wed, 05 Mar 2025)
Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
A Source/WebCore/rendering/PositionedLayoutConstraints.cpp
A Source/WebCore/rendering/PositionedLayoutConstraints.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderLayer.cpp
Log Message:
-----------
[Cleanup] Move PositionedLayoutConstraints to a dedicated file
https://bugs.webkit.org/show_bug.cgi?id=289108
Reviewed by Antti Koivisto.
1. Move PositionedLayoutConstraints and LayoutRange to
PositionedLayoutConstraints.h/cpp
2. Move public member variables to private
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/rendering/PositionedLayoutConstraints.cpp: Added.
(WebCore::shouldFlipStaticPositionInParent):
(WebCore::PositionedLayoutConstraints::PositionedLayoutConstraints):
(WebCore::PositionedLayoutConstraints::needsAnchor const):
(WebCore::PositionedLayoutConstraints::containingCoordsAreFlipped const):
(WebCore::PositionedLayoutConstraints::captureInsets):
(WebCore::PositionedLayoutConstraints::computeAnchorGeometry):
(WebCore::PositionedLayoutConstraints::adjustForPositionArea):
(WebCore::PositionedLayoutConstraints::resolvePosition const):
(WebCore::PositionedLayoutConstraints::resolveAlignmentAdjustment const):
(WebCore::PositionedLayoutConstraints::resolveAlignmentPosition const):
(WebCore::PositionedLayoutConstraints::alignmentAppliesStretch const):
(WebCore::PositionedLayoutConstraints::computeInlineStaticDistance):
(WebCore::PositionedLayoutConstraints::convertedLogicalLeftValue const):
(WebCore::PositionedLayoutConstraints::computeBlockStaticDistance):
(WebCore::PositionedLayoutConstraints::convertedLogicalTopValue const):
* Source/WebCore/rendering/PositionedLayoutConstraints.h: Added.
(WebCore::LayoutRange::LayoutRange):
(WebCore::LayoutRange::min const):
(WebCore::LayoutRange::max const):
(WebCore::LayoutRange::size const):
(WebCore::LayoutRange::set):
(WebCore::LayoutRange::reset):
(WebCore::LayoutRange::moveBy):
(WebCore::LayoutRange::moveTo):
(WebCore::LayoutRange::shiftMinEdgeBy):
(WebCore::LayoutRange::shiftMaxEdgeBy):
(WebCore::LayoutRange::shiftMinEdgeTo):
(WebCore::LayoutRange::shiftMaxEdgeTo):
(WebCore::PositionedLayoutConstraints::marginBefore const):
(WebCore::PositionedLayoutConstraints::marginAfter const):
(WebCore::PositionedLayoutConstraints::insetBefore const):
(WebCore::PositionedLayoutConstraints::insetAfter const):
(WebCore::PositionedLayoutConstraints::container const):
(WebCore::PositionedLayoutConstraints::defaultAnchorBox const):
(WebCore::PositionedLayoutConstraints::bordersPlusPadding const):
(WebCore::PositionedLayoutConstraints::alignment const):
(WebCore::PositionedLayoutConstraints::containingAxis const):
(WebCore::PositionedLayoutConstraints::physicalAxis const):
(WebCore::PositionedLayoutConstraints::containingWritingMode const):
(WebCore::PositionedLayoutConstraints::isOrthogonal const):
(WebCore::PositionedLayoutConstraints::isBlockOpposing const):
(WebCore::PositionedLayoutConstraints::isBlockFlipped const):
(WebCore::PositionedLayoutConstraints::isLogicalLeftInlineStart const):
(WebCore::PositionedLayoutConstraints::containingSize const):
(WebCore::PositionedLayoutConstraints::marginBeforeValue const):
(WebCore::PositionedLayoutConstraints::marginAfterValue const):
(WebCore::PositionedLayoutConstraints::insetBeforeValue const):
(WebCore::PositionedLayoutConstraints::insetAfterValue const):
(WebCore::PositionedLayoutConstraints::availableContentSpace const):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidth const):
(WebCore::RenderBox::computePositionedLogicalWidthUsing const):
(WebCore::RenderBox::computePositionedLogicalHeight const):
(WebCore::RenderBox::computePositionedLogicalHeightUsing const):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced const):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced const):
(WebCore::RenderBox::computeAnchorCenteredPosition const):
(WebCore::LayoutRange::LayoutRange): Deleted.
(WebCore::LayoutRange::min const): Deleted.
(WebCore::LayoutRange::max const): Deleted.
(WebCore::LayoutRange::size const): Deleted.
(WebCore::LayoutRange::set): Deleted.
(WebCore::LayoutRange::reset): Deleted.
(WebCore::LayoutRange::moveBy): Deleted.
(WebCore::LayoutRange::moveTo): Deleted.
(WebCore::LayoutRange::shiftMinEdgeBy): Deleted.
(WebCore::LayoutRange::shiftMaxEdgeBy): Deleted.
(WebCore::LayoutRange::shiftMinEdgeTo): Deleted.
(WebCore::LayoutRange::shiftMaxEdgeTo): Deleted.
(): Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::needsAnchor const): Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::isOrthogonal const): Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::isBlockOpposing const):
Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::isBlockFlipped const):
Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::isLogicalLeftInlineStart
const): Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::containingCoordsAreFlipped
const): Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::containingSize const):
Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::marginBeforeValue const):
Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::marginAfterValue const):
Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::insetBeforeValue const):
Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::insetAfterValue const):
Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::availableContentSpace const):
Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::PositionedLayoutConstraints):
Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::captureInsets): Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::computeAnchorGeometry):
Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::adjustForPositionArea):
Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::resolvePosition const):
Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::resolveAlignmentAdjustment
const): Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::resolveAlignmentPosition
const): Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::alignmentAppliesStretch
const): Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::computeInlineStaticDistance):
Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::convertLogicalLeftValue
const): Deleted.
(WebCore::shouldFlipStaticPositionInParent): Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::computeBlockStaticDistance):
Deleted.
(WebCore::RenderBox::PositionedLayoutConstraints::convertLogicalTopValue
const): Deleted.
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderLayer.cpp:
Canonical link: https://commits.webkit.org/291678@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
