Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2f017d5b2c03fba704bb135506d9c2fbe78b9c9f
      
https://github.com/WebKit/WebKit/commit/2f017d5b2c03fba704bb135506d9c2fbe78b9c9f
  Author: Joshua Hoffman <jhoffma...@apple.com>
  Date:   2025-03-05 (Wed, 05 Mar 2025)

  Changed paths:
    M Source/WebCore/accessibility/AXTextMarker.cpp
    M Source/WebCore/accessibility/AXTextMarker.h

  Log Message:
  -----------
  AX: [AX Thread Text APIs] Downgrade release asserts in AXTextMarker
https://bugs.webkit.org/show_bug.cgi?id=289118
rdar://146146886

Reviewed by Tyler Wilcock.

This PR downgrades the release asserts in AXTextMarker to debug, adds 
appropriate
fallbacks when these conditions fail, and adds new logging to help diagnose 
issues
when we hit them.

`accessibility/ax-thread-text-apis` and `accessibility/isolated-tree` do not 
change
their pass rate with this change.

* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::AXTextMarkerRange::characterRange const):
(WebCore::AXTextMarker::lineIndex const):
(WebCore::AXTextMarker::characterRangeForLine const):
(WebCore::AXTextMarker::markerRangeForLineIndex const):
(WebCore::AXTextMarker::atLineBoundaryForDirection const):
(WebCore::AXTextMarker::offsetFromRoot const):
(WebCore::AXTextMarker::findMarker const):
(WebCore::AXTextMarker::findLine const):
(WebCore::AXTextMarker::findParagraph const):
(WebCore::AXTextMarker::toTextRunMarker const):
(WebCore::AXTextMarker::partialOrderByTraversal const):
* Source/WebCore/accessibility/AXTextMarker.h:

Canonical link: https://commits.webkit.org/291629@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to