Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d0061c38590bdee6e6881f42c9d5e126de965915
https://github.com/WebKit/WebKit/commit/d0061c38590bdee6e6881f42c9d5e126de965915
Author: Jer Noble <jer.no...@apple.com>
Date: 2025-03-05 (Wed, 05 Mar 2025)
Changed paths:
M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm
Log Message:
-----------
CRASH in VideoPresentationInterfaceIOS::ensurePipPlacardIsShowing
rdar://146108129
https://bugs.webkit.org/show_bug.cgi?id=289107
Reviewed by Brent Fulgham.
Crash logging shows an exception thrown from +[NSArray arrayWithObjects:count:]
within
ensurePipPlacardIsShowing(), which can only be caused by a nil object being
inserted into
an objective-c literal NSArray. There are a couple of code paths which generate
a literal
array in that method, but given that the failure case is that the plackard
informing the user that the video is in PiP will not be shown, we should
probably not
crash here. Wrap the method in a try/catch block.
* Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm:
(WebCore::VideoPresentationInterfaceIOS::ensurePipPlacardIsShowing):
Canonical link: https://commits.webkit.org/291622@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
