Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b2c8205237ab80de04f20ae98687373a645ca27f
https://github.com/WebKit/WebKit/commit/b2c8205237ab80de04f20ae98687373a645ca27f
Author: Elika Etemad <fantasai.b...@inkedblade.net>
Date: 2025-03-03 (Mon, 03 Mar 2025)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-014-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/auto-margins-position-area-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/last-successful-basic-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/last-successful-change-fallbacks-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/last-successful-change-try-rule-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/last-successful-intermediate-ignored-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-align-justify-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-align-justify-wm-dir-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-in-position-try-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-scrolling-003.tentative-expected.txt
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/style/PositionArea.cpp
M Source/WebCore/rendering/style/PositionArea.h
Log Message:
-----------
Integrate position-area and self-alignment properties
(align-self/justify-self)
https://bugs.webkit.org/show_bug.cgi?id=288886
rdar://145889235
Reviewed by Antti Koivisto.
Incorporates position-area defaults into alignment resolution by adding
a method to return the default alignment in PositionArea and incorporating
that into positioned layout code through new alignment resolution methods
on PositionedLayoutConstraints.
Also caches RenderStyle into PositionedLayoutConstraints, because we need
it during alignment.
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/anchor-scroll-position-try-014-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/auto-margins-position-area-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/last-successful-basic-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/last-successful-change-fallbacks-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/last-successful-change-try-rule-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/last-successful-intermediate-ignored-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-align-justify-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-align-justify-wm-dir-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-in-position-try-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-area-scrolling-003.tentative-expected.txt:
* Source/WebCore/rendering/RenderBox.cpp: Cache RenderStyle into
PositionedLayoutConstraints.
(WebCore::RenderBox::PositionedLayoutConstraints::needsAnchor const):
(WebCore::RenderBox::PositionedLayoutConstraints::PositionedLayoutConstraints):
(WebCore::RenderBox::PositionedLayoutConstraints::captureInsets):
(WebCore::RenderBox::PositionedLayoutConstraints::computeAnchorGeometry):
(WebCore::RenderBox::PositionedLayoutConstraints::adjustForPositionArea):
* Source/WebCore/rendering/RenderBox.cpp: Integrate position-area default
alignment.
(WebCore::RenderBox::PositionedLayoutConstraints::resolveAlignmentAdjustment
const): Update to use new alignment resolution method.
(WebCore::RenderBox::PositionedLayoutConstraints::resolveAlignmentPosition
const): Add alignment resolution method.
(WebCore::RenderBox::PositionedLayoutConstraints::alignmentAppliesStretch
const): Add alignment resolution method.
(WebCore::RenderBox::computePositionedLogicalWidth const): Update alignment
check to use resolution method.
(WebCore::RenderBox::computePositionedLogicalWidthUsing const): Update
alignment check to use resolution method.
(WebCore::RenderBox::computePositionedLogicalHeight const): Update alignment
check to use resolution method.
(WebCore::RenderBox::computePositionedLogicalHeightUsing const): Update
alignment check to use resolution method.
* Source/WebCore/rendering/style/PositionArea.cpp:
(WebCore::PositionArea::spanForAxis const): Add helper method.
(WebCore::PositionArea::coordMatchedTrackForAxis const): Update to use helper
method.
(WebCore::flip): Add helper function.
(WebCore::PositionArea::defaultAlignmentForAxis const): Implement method to
return default alignment.
* Source/WebCore/rendering/style/PositionArea.h:
Canonical link: https://commits.webkit.org/291552@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
