Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 86ce2d141b16d02c7c0856a8c123a50248cef321
      
https://github.com/WebKit/WebKit/commit/86ce2d141b16d02c7c0856a8c123a50248cef321
  Author: Kiet Ho <kiet...@apple.com>
  Date:   2025-03-01 (Sat, 01 Mar 2025)

  Changed paths:
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-computed-expected.txt
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-computed.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-computed.tentative-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-computed.tentative.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-parsing-expected.txt
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-parsing.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-parsing.tentative-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-parsing.tentative.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-list.js
    M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M 
LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt
    M 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt
    M 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSValueKeywords.in
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Anchor.cpp
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Anchor.h
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleConstants.cpp
    M Source/WebCore/rendering/style/RenderStyleConstants.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/rendering/style/RenderStyleSetters.h
    M Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp
    M Source/WebCore/rendering/style/StyleRareNonInheritedData.h
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  [css-anchor-position-1] Implement parsing `position-visibility`
rdar://141799808
https://bugs.webkit.org/show_bug.cgi?id=285005

Reviewed by Antti Koivisto.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-computed-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-computed.html:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-computed.tentative.html.
    - Rewrite tests to match current definition in the spec, and mark it as 
official test.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-computed.tentative-expected.txt:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-parsing-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-parsing.html:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-parsing.tentative.html.
    - Rewrite tests to match current definition in the spec and mark it as 
official test.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-parsing.tentative-expected.txt:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-list.js:
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* 
LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
* 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
* 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
    - Define fromCSSValueID() and toCSSValueID() for PositionVisibility

* Source/WebCore/css/CSSProperties.json:
    - Add entry for position-visibility

* Source/WebCore/css/CSSValueKeywords.in:
    - Add keywords used in position-visibility

* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::valueForPositionVisibility):
    - Add function to serialize PositionVisibility
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
    - Support serializing position-visibility

* Source/WebCore/css/parser/CSSPropertyParserConsumer+Anchor.cpp:
(WebCore::CSSPropertyParserHelpers::consumePositionVisibility):
    - Add function to parse position-visibility value

* Source/WebCore/css/parser/CSSPropertyParserConsumer+Anchor.h:
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const):
* Source/WebCore/rendering/style/RenderStyle.h:
    - Add initial/getter/setter functions for position-visibility

* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
    - Implement operator<<(TextStream, ) for PositionVisibility

* Source/WebCore/rendering/style/RenderStyleConstants.h:
    - Add PositionVisibility enum type

* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::initialPositionVisibility):
(WebCore::RenderStyle::positionVisibility const):
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setPositionVisibility):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):
(WebCore::StyleRareNonInheritedData::dumpDifferences const):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.h:
    - Add storage in RenderStyle for position-visibility
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertPositionVisibility):
    - Add function to convert CSSValue to OptionSet<PositionVisibility>

Canonical link: https://commits.webkit.org/291457@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to