Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4912508a6d26dec6478027222442371154d1a125
https://github.com/WebKit/WebKit/commit/4912508a6d26dec6478027222442371154d1a125
Author: Chris Dumez <cdu...@apple.com>
Date: 2025-03-01 (Sat, 01 Mar 2025)
Changed paths:
M Source/WebCore/Modules/webauthn/fido/Pin.cpp
M Source/WebCore/Modules/webauthn/fido/Pin.h
M Source/WebKit/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M
Source/WebKit/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebKit/UIProcess/API/APIWebAuthenticationAssertionResponse.h
M Source/WebKit/UIProcess/API/APIWebAuthenticationPanel.cpp
M Source/WebKit/UIProcess/API/APIWebAuthenticationPanel.h
M Source/WebKit/UIProcess/WebAuthentication/Authenticator.cpp
M Source/WebKit/UIProcess/WebAuthentication/Authenticator.h
M Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp
M Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h
M Source/WebKit/UIProcess/WebAuthentication/AuthenticatorTransportService.h
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/CcidConnection.mm
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/CcidService.mm
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/NfcService.mm
M
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm
M Source/WebKit/UIProcess/WebAuthentication/Mock/MockNfcService.mm
M
Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h
M Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualService.mm
M Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp
M Source/WebKit/UIProcess/WebAuthentication/fido/CtapCcidDriver.cpp
M Source/WebKit/UIProcess/WebAuthentication/fido/CtapCcidDriver.h
M Source/WebKit/UIProcess/WebAuthentication/fido/CtapNfcDriver.h
M Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.cpp
M Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.h
M Source/WebKit/UIProcess/WebAuthentication/fido/FidoService.cpp
M Source/WebKit/UIProcess/WebAuthentication/fido/FidoService.h
M Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp
Log Message:
-----------
Address safer cpp failures in WebKit/UIProcess/WebAuthentication
https://bugs.webkit.org/show_bug.cgi?id=288883
Reviewed by Darin Adler.
* Source/WebCore/Modules/webauthn/fido/Pin.cpp:
(fido::pin::TokenRequest::sharedKey const): Deleted.
(fido::pin::SetPinRequest::sharedKey const): Deleted.
* Source/WebCore/Modules/webauthn/fido/Pin.h:
(fido::pin::SetPinRequest::sharedKey const):
(fido::pin::TokenRequest::sharedKey const):
* Source/WebKit/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/UIProcess/API/APIWebAuthenticationAssertionResponse.h:
* Source/WebKit/UIProcess/API/APIWebAuthenticationPanel.cpp:
(API::WebAuthenticationPanel::protectedClient const):
* Source/WebKit/UIProcess/API/APIWebAuthenticationPanel.h:
* Source/WebKit/UIProcess/WebAuthentication/Authenticator.cpp:
(WebKit::Authenticator::handleRequest):
* Source/WebKit/UIProcess/WebAuthentication/Authenticator.h:
(WebKit::Authenticator::protectedObserver const):
* Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::serviceStatusUpdated):
(WebKit::AuthenticatorManager::downgrade):
(WebKit::AuthenticatorManager::authenticatorStatusUpdated):
(WebKit::AuthenticatorManager::requestPin):
(WebKit::AuthenticatorManager::requestNewPin):
(WebKit::AuthenticatorManager::selectAssertionResponse):
(WebKit::AuthenticatorManager::decidePolicyForLocalAuthenticator):
(WebKit::AuthenticatorManager::requestLAContextForUserVerification):
(WebKit::AuthenticatorManager::runPanel):
(WebKit::AuthenticatorManager::invokePendingCompletionHandler):
* Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h:
(isType):
* Source/WebKit/UIProcess/WebAuthentication/AuthenticatorTransportService.h:
(WebKit::AuthenticatorTransportServiceObserver::isAuthenticatorManager const):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/CcidConnection.mm:
(WebKit::CcidConnection::transact const):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/CcidService.mm:
(WebKit::CcidService::updateSlots):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:
(WebKit::LocalService::startDiscoveryInternal):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/NfcService.mm:
(WebKit::NfcService::didDetectMultipleTags const):
(WebKit::NfcService::restartDiscoveryInternal):
(WebKit::NfcService::platformStartDiscovery):
*
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm:
(WebKit::WebAuthenticationPanelClient::selectAssertionResponse const):
* Source/WebKit/UIProcess/WebAuthentication/Mock/MockNfcService.mm:
(WebKit::MockNfcService::platformStartDiscovery):
*
Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h:
(isType):
* Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualService.mm:
(WebKit::VirtualService::startDiscoveryInternal):
* Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:
(WebKit::CtapAuthenticator::makeCredential):
(WebKit::CtapAuthenticator::continueMakeCredentialAfterResponseReceived):
(WebKit::CtapAuthenticator::getAssertion):
(WebKit::CtapAuthenticator::continueGetAssertionAfterResponseReceived):
(WebKit::CtapAuthenticator::continueGetNextAssertionAfterResponseReceived):
(WebKit::CtapAuthenticator::getRetries):
(WebKit::CtapAuthenticator::continueGetKeyAgreementAfterGetRetries):
(WebKit::CtapAuthenticator::continueRequestPinAfterGetKeyAgreement):
(WebKit::CtapAuthenticator::continueGetPinTokenAfterRequestPin):
(WebKit::CtapAuthenticator::tryDowngrade):
(WebKit::CtapAuthenticator::continueSetupPinAfterCommand):
(WebKit::CtapAuthenticator::continueSetupPinAfterGetKeyAgreement):
(WebKit::CtapAuthenticator::setupPin):
(WebKit::CtapAuthenticator::performAuthenticatorSelectionForSetupPin):
* Source/WebKit/UIProcess/WebAuthentication/fido/CtapCcidDriver.cpp:
(WebKit::CtapCcidDriver::transact):
* Source/WebKit/UIProcess/WebAuthentication/fido/CtapCcidDriver.h:
* Source/WebKit/UIProcess/WebAuthentication/fido/CtapNfcDriver.h:
* Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.cpp:
(WebKit::FidoAuthenticator::protectedDriver const):
* Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.h:
* Source/WebKit/UIProcess/WebAuthentication/fido/FidoService.cpp:
(WebKit::FidoService::getInfo):
(WebKit::FidoService::continueAfterGetInfo):
* Source/WebKit/UIProcess/WebAuthentication/fido/FidoService.h:
* Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp:
(WebKit::U2fAuthenticator::issueCommand):
Canonical link: https://commits.webkit.org/291449@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
