Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c4e24f803946d64a724d5b35a85f8b625cdfdafa https://github.com/WebKit/WebKit/commit/c4e24f803946d64a724d5b35a85f8b625cdfdafa Author: Tim Nguyen <n...@apple.com> Date: 2025-02-28 (Fri, 28 Feb 2025)
Changed paths: M Source/WebCore/bindings/js/WebCoreBuiltinNames.h M Source/WebCore/dom/CaretPosition.idl Log Message: ----------- CaretPosition should be EnabledBySetting https://bugs.webkit.org/show_bug.cgi?id=288644 rdar://145688017 Reviewed by Simon Fraser. https://commits.webkit.org/287047@main (bug 172137) added Document.caretPositionFromPoint(). However, while Document.caretPositionFromPoint() itself has [EnabledBySetting=CaretPositionFromPointEnabled] neither CaretPosition nor CaretPositionFromPointOptions do. These should also be behind the flag, because otherwise we break anyone doing anything like `if (window.CaretPosition)` or the mdn-bcd-collector trying to fetch meaningful data about what browser supports the related APIs. * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/dom/CaretPosition.idl: Canonical link: https://commits.webkit.org/291314@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes