Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c03c8f376cdaaa9c20815398897fbf22fe593f33
https://github.com/WebKit/WebKit/commit/c03c8f376cdaaa9c20815398897fbf22fe593f33
Author: Alex Christensen <achristen...@apple.com>
Date: 2025-02-27 (Thu, 27 Feb 2025)
Changed paths:
A Source/WebCore/Modules/webxr/XRSubImage.cpp
M Source/WebCore/Modules/webxr/XRSubImage.h
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
Log Message:
-----------
Fix debug visionOS build
https://bugs.webkit.org/show_bug.cgi?id=288704
Reviewed by Mike Wyrzykowski.
It currently failius with a linker error like this:
Undefined symbols for architecture arm64:
"vtable for WebCore::XRSubImage", referenced from:
WebCore::toJSNewlyCreated(...)
NOTE: a missing vtable usually means the first non-inline virtual member
function has no definition.
This is fixed by making the destructor not defined inline. This makes the
linker need to find it
in a .o file instead of having each compilation unit notice that it's inline
and make no reference
to it for the linker to find.
* Source/WebCore/Modules/webxr/XRSubImage.cpp: Copied from
Source/WebCore/Modules/webxr/XRSubImage.h.
* Source/WebCore/Modules/webxr/XRSubImage.h:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/291220@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
