Title: [112204] trunk/LayoutTests
- Revision
- 112204
- Author
- [email protected]
- Date
- 2012-03-26 21:25:16 -0700 (Mon, 26 Mar 2012)
Log Message
Fix flaky test fast/eventsource/eventsource-url-attribute.html
https://bugs.webkit.org/show_bug.cgi?id=82257
Patch by Pablo Flouret <[email protected]> on 2012-03-26
Reviewed by Ryosuke Niwa.
The test used http://localhost, chosen as a semi-random url, but since
it doesn't return a text/event-stream mime-type sometimes a console
warning would appear. Moved the test to the http folder and changed it
to use a resource with the correct mime-type.
* http/tests/eventsource/eventsource-url-attribute-expected.txt: Renamed from LayoutTests/fast/eventsource/eventsource-url-attribute-expected.txt.
* http/tests/eventsource/eventsource-url-attribute.html: Renamed from LayoutTests/fast/eventsource/eventsource-url-attribute.html.
Modified Paths
Added Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (112203 => 112204)
--- trunk/LayoutTests/ChangeLog 2012-03-27 03:58:35 UTC (rev 112203)
+++ trunk/LayoutTests/ChangeLog 2012-03-27 04:25:16 UTC (rev 112204)
@@ -1,3 +1,18 @@
+2012-03-26 Pablo Flouret <[email protected]>
+
+ Fix flaky test fast/eventsource/eventsource-url-attribute.html
+ https://bugs.webkit.org/show_bug.cgi?id=82257
+
+ Reviewed by Ryosuke Niwa.
+
+ The test used http://localhost, chosen as a semi-random url, but since
+ it doesn't return a text/event-stream mime-type sometimes a console
+ warning would appear. Moved the test to the http folder and changed it
+ to use a resource with the correct mime-type.
+
+ * http/tests/eventsource/eventsource-url-attribute-expected.txt: Renamed from LayoutTests/fast/eventsource/eventsource-url-attribute-expected.txt.
+ * http/tests/eventsource/eventsource-url-attribute.html: Renamed from LayoutTests/fast/eventsource/eventsource-url-attribute.html.
+
2012-03-26 David Grogan <[email protected]>
Extract logic of indexeddb html layout tests into js files that can
Deleted: trunk/LayoutTests/fast/eventsource/eventsource-url-attribute-expected.txt (112203 => 112204)
--- trunk/LayoutTests/fast/eventsource/eventsource-url-attribute-expected.txt 2012-03-27 03:58:35 UTC (rev 112203)
+++ trunk/LayoutTests/fast/eventsource/eventsource-url-attribute-expected.txt 2012-03-27 04:25:16 UTC (rev 112204)
@@ -1,12 +0,0 @@
-Both .URL and .url should work (for compatibility reasons).
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS source.URL is "http://localhost/"
-PASS source.url is "http://localhost/"
-PASS source.URL ="" source.url is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/eventsource/eventsource-url-attribute.html (112203 => 112204)
--- trunk/LayoutTests/fast/eventsource/eventsource-url-attribute.html 2012-03-27 03:58:35 UTC (rev 112203)
+++ trunk/LayoutTests/fast/eventsource/eventsource-url-attribute.html 2012-03-27 04:25:16 UTC (rev 112204)
@@ -1,22 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<meta charset="utf-8">
-<script src=""
-</head>
-<body>
-<script>
-
-description("Both .URL and .url should work (for compatibility reasons).");
-
-var url = ""
-var source = new EventSource(url);
-
-shouldBeEqualToString("source.URL", url);
-shouldBeEqualToString("source.url", url);
-shouldBeTrue("source.URL ="" source.url");
-
-</script>
-<script src=""
-</body>
-</html>
Copied: trunk/LayoutTests/http/tests/eventsource/eventsource-url-attribute-expected.txt (from rev 112203, trunk/LayoutTests/fast/eventsource/eventsource-url-attribute-expected.txt) (0 => 112204)
--- trunk/LayoutTests/http/tests/eventsource/eventsource-url-attribute-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/eventsource/eventsource-url-attribute-expected.txt 2012-03-27 04:25:16 UTC (rev 112204)
@@ -0,0 +1,12 @@
+Both .URL and .url should work (for compatibility reasons).
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS source.URL is "http://127.0.0.1:8000/eventsource/resources/event-stream.php"
+PASS source.url is "http://127.0.0.1:8000/eventsource/resources/event-stream.php"
+PASS source.URL ="" source.url is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: trunk/LayoutTests/http/tests/eventsource/eventsource-url-attribute.html (from rev 112203, trunk/LayoutTests/fast/eventsource/eventsource-url-attribute.html) (0 => 112204)
--- trunk/LayoutTests/http/tests/eventsource/eventsource-url-attribute.html (rev 0)
+++ trunk/LayoutTests/http/tests/eventsource/eventsource-url-attribute.html 2012-03-27 04:25:16 UTC (rev 112204)
@@ -0,0 +1,22 @@
+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<script src=""
+</head>
+<body>
+<script>
+
+description("Both .URL and .url should work (for compatibility reasons).");
+
+var url = ""
+var source = new EventSource(url);
+
+shouldBeEqualToString("source.URL", url);
+shouldBeEqualToString("source.url", url);
+shouldBeTrue("source.URL ="" source.url");
+
+</script>
+<script src=""
+</body>
+</html>
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
