Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 674c233ca729f76a87bb6686a1f74bd6ffb602a6
https://github.com/WebKit/WebKit/commit/674c233ca729f76a87bb6686a1f74bd6ffb602a6
Author: Alan Baradlay <za...@apple.com>
Date: 2025-02-05 (Wed, 05 Feb 2025)
Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/layout/integration/inline/InlineIteratorBoxLegacyPath.h
M Source/WebCore/layout/integration/inline/InlineIteratorTextBox.cpp
M Source/WebCore/rendering/LegacyInlineTextBox.cpp
M Source/WebCore/rendering/LegacyInlineTextBox.h
M Source/WebCore/rendering/LegacyLineLayout.cpp
M Source/WebCore/rendering/RenderText.cpp
M Source/WebCore/rendering/RenderText.h
M Source/WebCore/rendering/RenderTextLineBoxes.cpp
M Source/WebCore/rendering/RenderTextLineBoxes.h
M Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
M Source/WebCore/rendering/svg/RenderSVGInlineText.h
M Source/WebCore/rendering/svg/SVGInlineTextBox.h
M Source/WebCore/rendering/svg/SVGInlineTextBoxInlines.h
M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp
Log Message:
-----------
[Cleanup] RenderText::m_legacyLineBoxes belongs to RenderSVGInlineText
https://bugs.webkit.org/show_bug.cgi?id=286875
Reviewed by Antti Koivisto.
We only construct legacy text boxes for svg content (RenderSVGInlineText).
* Source/WebCore/layout/integration/inline/InlineIteratorTextBox.cpp:
(WebCore::InlineIterator::lineLeftmostTextBoxFor):
* Source/WebCore/rendering/LegacyInlineTextBox.h:
(WebCore::LegacyInlineTextBox::LegacyInlineTextBox):
(WebCore::LegacyInlineTextBox::renderer const):
* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::createInlineBoxForRenderer):
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::LegacyLineLayout::removeInlineBox const):
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::willBeDestroyed): this is redundant.
removeAndDestroyLegacyTextBoxes is called by resetRendererStateOnDetach.
(WebCore::RenderText::setTextWithOffset):
(WebCore::RenderText::removeAndDestroyLegacyTextBoxes): Deleted.
(WebCore::RenderText::deleteLegacyLineBoxes): Deleted.
(WebCore::RenderText::createTextBox): Deleted.
* Source/WebCore/rendering/RenderText.h:
(WebCore::RenderText::removeTextBox): Deleted.
(WebCore::RenderText::createInlineTextBox): Deleted.
(WebCore::RenderText::firstLegacyTextBox const): Deleted.
* Source/WebCore/rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::createAndAppendLineBox):
(WebCore::RenderTextLineBoxes::removeAllFromParent):
(WebCore::RenderTextLineBoxes::dirtyForTextChange):
(WebCore::RenderTextLineBoxes::dirtyAll): Deleted.
* Source/WebCore/rendering/RenderTextLineBoxes.h:
* Source/WebCore/rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::setTextInternal):
(WebCore::RenderSVGInlineText::deleteLegacyLineBoxes):
(WebCore::RenderSVGInlineText::removeAndDestroyLegacyTextBoxes):
* Source/WebCore/rendering/svg/RenderSVGInlineText.h:
* Source/WebCore/rendering/svg/SVGInlineTextBox.h:
* Source/WebCore/rendering/svg/SVGInlineTextBoxInlines.h:
(WebCore::SVGInlineTextBox::renderer const): Deleted.
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::resetRendererStateOnDetach):
* Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp:
(WebCore::RenderTreeBuilder::FirstLetter::updateStyle):
Canonical link: https://commits.webkit.org/289861@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
