Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: faec608ad6c7afa447303f174843ff400fb03ca6
https://github.com/WebKit/WebKit/commit/faec608ad6c7afa447303f174843ff400fb03ca6
Author: Lauro Moura <lmo...@igalia.com>
Date: 2025-02-03 (Mon, 03 Feb 2025)
Changed paths:
M Source/WebDriver/CommandResult.cpp
M Source/WebDriver/CommandResult.h
M Source/WebDriver/WebDriverService.cpp
M Source/WebDriver/WebSocketServer.cpp
Log Message:
-----------
[WebDriver][BiDi] Fix error response id, type, and error name fields
https://bugs.webkit.org/show_bug.cgi?id=286163
Reviewed by Carlos Garcia Campos.
- Attach the command's "id" field in some `Message::fail` calls,
so the client know what command caused the error response
- Add the "type" field, with value "error", mirroring the other
types ("event", and "response")
- The "error" field should be the JSON error name string, per
https://w3c.github.io/webdriver/#dfn-error-code. Currently,
we were sending the corresponding HTTP status code.
* Source/WebDriver/CommandResult.cpp:
(WebDriver::CommandResult::errorString const):
(WebDriver::CommandResult::errorCodeToErrorString):
* Source/WebDriver/CommandResult.h:
* Source/WebDriver/WebDriverService.cpp:
(WebDriver::WebDriverService::bidiSessionSubscribe):
(WebDriver::WebDriverService::bidiSessionUnsubscribe):
* Source/WebDriver/WebSocketServer.cpp:
(WebDriver::WebSocketMessageHandler::Message::fail):
Canonical link: https://commits.webkit.org/289728@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
