Title: [112066] trunk/Source/WebCore
- Revision
- 112066
- Author
- loi...@chromium.org
- Date
- 2012-03-26 02:07:43 -0700 (Mon, 26 Mar 2012)
Log Message
Web Inspector: replace indexOf('a text') === 0 with RegExp because it is much faster.
https://bugs.webkit.org/show_bug.cgi?id=82175
We were using aString.indexOf("Window") but it is not effective from performance point of view.
I'm replaced it with RegExp.
Reviewed by Yury Semikhatsky.
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get isWindow):
(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTree):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (112065 => 112066)
--- trunk/Source/WebCore/ChangeLog 2012-03-26 09:04:07 UTC (rev 112065)
+++ trunk/Source/WebCore/ChangeLog 2012-03-26 09:07:43 UTC (rev 112066)
@@ -1,3 +1,17 @@
+2012-03-26 Ilya Tikhonovsky <loi...@chromium.org>
+
+ Web Inspector: replace indexOf('a text') === 0 with RegExp because it is much faster.
+ https://bugs.webkit.org/show_bug.cgi?id=82175
+
+ We were using aString.indexOf("Window") but it is not effective from performance point of view.
+ I'm replaced it with RegExp.
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/front-end/HeapSnapshot.js:
+ (WebInspector.HeapSnapshotNode.prototype.get isWindow):
+ (WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTree):
+
2012-03-26 Pavel Feldman <pfeld...@chromium.org>
Web Inspector: breakpoints should be disabled while live editing _javascript_.
Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js (112065 => 112066)
--- trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js 2012-03-26 09:04:07 UTC (rev 112065)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js 2012-03-26 09:07:43 UTC (rev 112066)
@@ -634,7 +634,8 @@
get isWindow()
{
- return this.name.indexOf("Window") === 0;
+ const windowRE = /^Window/;
+ return windowRE.test(this.name);
},
get isDetachedDOMTreesRoot()
@@ -644,7 +645,8 @@
get isDetachedDOMTree()
{
- return this.className.indexOf("Detached DOM tree") === 0;
+ const detachedDOMTreeRE = /^Detached DOM tree/;
+ return detachedDOMTreeRE.test(this.className);
},
get isRoot()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
