Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b54f74dc48ddd482b8ecc2409fb8571d8885aeab
https://github.com/WebKit/WebKit/commit/b54f74dc48ddd482b8ecc2409fb8571d8885aeab
Author: Jer Noble <jer.no...@apple.com>
Date: 2025-01-24 (Fri, 24 Jan 2025)
Changed paths:
M Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp
Log Message:
-----------
[Cocoa] Align MediaAccessibility-to-CSS border-radius behavior with Blink
https://bugs.webkit.org/show_bug.cgi?id=286502
rdar://142835074
Reviewed by Tim Nguyen.
Historically, WebKit has added a `4em` padding value when the user's preferred
subtitle
style used an opaque window. However, that led to extremely large padding
values when
compared to Blink, which resulted in significantly different layouts on real
sites.
Instead of a `4em` padding, make the size of the padding relative to the border
radius.
Blink appears to use a `border-radius / 4` to determine the padding for cues,
so replicate
that math here.
* Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::captionsWindowCSS const):
(WebCore::CaptionUserPreferencesMediaAF::windowRoundedCornerRadiusCSS const):
Canonical link: https://commits.webkit.org/289368@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
