Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7090e844eec54fcae5a538606c06165818a0f990
https://github.com/WebKit/WebKit/commit/7090e844eec54fcae5a538606c06165818a0f990
Author: Alex Christensen <[email protected]>
Date: 2025-01-22 (Wed, 22 Jan 2025)
Changed paths:
M Source/WebCore/platform/LocalizedStrings.cpp
Log Message:
-----------
Remove threading assertion in copyLocalizedString
https://bugs.webkit.org/show_bug.cgi?id=286385
rdar://143431906
Reviewed by David Kilzer.
The function seems thread safe, and if you run accessibility layout tests with
--accessibility-isolated-tree
you get several assertions in that function, such as stacks like this:
WTFCrashWithInfo(int, char const*, char const*, int) + 100
WebCore::copyLocalizedString(__CFString const*) + 148 (LocalizedStrings.cpp:105)
WebCore::localizedString(__CFString const*) + 44 (LocalizedStrings.cpp:127)
-[WebAccessibilityObjectWrapperBase accessibilityCustomContent] + 332
(WebAccessibilityObjectWrapperBase.mm:414)
WTR::AccessibilityUIElement::customContent() const::$_0::operator()() const +
96 (AccessibilityUIElementMac.mm:504)
WTF::Detail::CallableWrapper<WTR::AccessibilityUIElement::customContent()
const::$_0, void>::call() + 32 (Function.h:53)
WTF::Function<void ()>::operator()() const + 184 (Function.h:82)
WTR::AccessibilityController::executeOnAXThreadAndWait(WTF::Function<void
()>&&)::$_0::operator()() const + 36 (AccessibilityController.cpp:117)
WTF::Detail::CallableWrapper<WTR::AccessibilityController::executeOnAXThreadAndWait(WTF::Function<void
()>&&)::$_0, void>::call() + 32 (Function.h:53)
WTF::Function<void ()>::operator()() const + 184 (Function.h:82)
WTR::AXThread::dispatchFunctionsFromAXThread() + 260
(AccessibilityController.cpp:256)
WTR::AXThread::threadRunLoopSourceCallback() + 48
(AccessibilityControllerMac.mm:207)
WTR::AXThread::threadRunLoopSourceCallback(void*) + 28
(AccessibilityControllerMac.mm:201)
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::copyLocalizedString):
Canonical link: https://commits.webkit.org/289272@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
