Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c20306a535f37402e25c1c7b6bb3bc4ca3485a68
https://github.com/WebKit/WebKit/commit/c20306a535f37402e25c1c7b6bb3bc4ca3485a68
Author: Alex Christensen <[email protected]>
Date: 2025-01-22 (Wed, 22 Jan 2025)
Changed paths:
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/html/MediaElementSession.cpp
Log Message:
-----------
Make Document::isTopDocument and Document::mainFrameDocument consistent
https://bugs.webkit.org/show_bug.cgi?id=286097
rdar://143077999
Reviewed by Brady Eidson.
They had different behavior when site isolation was on.
This makes them always return the main frame's document when site isolation is
on.
This does not change behavior when site isolation is off.
http/tests/site-isolation/accessibility/hit-test-resolving-remote-frame.html
started failing after an earlier version of this change, but now it passes.
In order to keep videos working in iframes with site isolation on, I changed
MediaElementSession::playbackStateChangePermitted to not always forbid video
playing when the main frame document is null. Instead, I check null and
proceed.
There is still work to do here, but this will allow most behavior to work
as desired with regards to video and site isolation in the meantime.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::axObjectCache const):
(WebCore::Document::mainFrameDocument const):
(WebCore::Document::isTopDocument const): Deleted.
* Source/WebCore/dom/Document.h:
(WebCore::Document::isTopDocument const):
(WebCore::Document::isTopDocumentLegacy const): Deleted.
Canonical link: https://commits.webkit.org/289267@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
